mobile UI improvements

This commit is contained in:
2025-12-27 00:20:28 +01:00
parent 4f247c086a
commit 4640ef961b
3 changed files with 159 additions and 34 deletions

View File

@@ -505,81 +505,206 @@ button {
box-shadow: var(--shadow-sm); box-shadow: var(--shadow-sm);
} }
/* Mobile Landscape Optimization */
/* Staff Row Wrapper (Removed) */
/* .side-hint-note (Removed) */
/* Mobile Landscape Optimization */ /* Mobile Landscape Optimization */
@media (max-height: 500px) and (orientation: landscape) { @media (max-height: 500px) and (orientation: landscape) {
.app-header { .app-header {
padding: 4px var(--spacing-md); padding: 2px var(--spacing-md);
}
/* Hide Title/Logo to save space for content */
.app-header-left {
display: none;
} }
.main-stage { .main-stage {
padding: 4px; padding: 0;
flex-direction: row; flex-direction: column;
/* Side-by-side if screen is wide enough */ align-items: center;
align-items: stretch; justify-content: flex-start;
gap: var(--spacing-md); gap: 0;
} }
.card.sheet-music-card { .card.sheet-music-card {
max-width: 95vw; max-width: 95vw;
flex-direction: column;
flex-wrap: nowrap;
justify-content: flex-start;
align-items: center;
padding: 0;
width: 100%;
background: transparent;
box-shadow: none;
}
/* Staff Row: Horizontal Layout for Staff + Note Name */
.staff-row {
flex-direction: row; flex-direction: row;
flex-wrap: wrap;
justify-content: center; justify-content: center;
align-items: center; align-items: center;
padding: var(--spacing-sm); width: 100%;
margin-bottom: -10px;
gap: 16px;
/* Space between note and staff */
}
.side-hint-note {
display: block;
/* Show it here */
font-size: 1.5rem;
/* Reduced from 3rem */
margin-right: 0;
z-index: 10;
/* Prevent shrinking */
flex-shrink: 0;
} }
/* Specific adjustment for sheet music container */ /* Specific adjustment for sheet music container */
.sheet-music-container { .sheet-music-container {
width: auto; width: 100%;
flex: 1; flex: 0 0 auto;
min-width: 250px; transform: scale(1.1);
max-width: 50%; transform-origin: center top;
display: flex; /* Center it again */
justify-content: center; justify-content: center;
margin-bottom: -15px;
/* Negative margin to reduce gap (adjusted from -30px to prevent overlap) */
} }
/* Hint card should be on the side */ /* In Zen Mode, the feedback area is missing, so we need less negative margin (or even positive) to prevent overlap */
.card.sheet-music-card.zen-mode .sheet-music-container {
margin-bottom: 5px;
/* Add some breathing room since the feedback spacer is gone */
}
/* Hint card container (Fretboard + Note Name) */
.hint-card { .hint-card {
margin-top: 0; margin-top: 0;
margin-left: var(--spacing-md); /* Remove top margin */
flex: 1; flex: 1;
min-width: 250px; width: 100%;
max-width: 45%; max-width: 100%;
padding: var(--spacing-xs); padding: 0;
background: transparent;
display: flex;
flex-direction: row;
/* Side-by-side */
justify-content: center;
align-items: center;
gap: 8px;
/* Reduced gap from 16px */
} }
.hint-note { /* The note name inside hint card */
font-size: 1.2rem; .hint-card .hint-note {
margin-bottom: 2px; display: block;
font-size: 2rem;
/* Visible size */
margin-bottom: 0;
flex-shrink: 0;
font-weight: 800;
width: 4rem;
/* Fixed width to stabilize fretboard */
text-align: center;
} }
/* Make sure hint isn't huge and scrolls if needed */ /* Make fretboard larger */
.fretboard-container { .fretboard-container {
max-height: 150px; max-height: 180px;
overflow-y: hidden; overflow-y: hidden;
display: flex; display: flex;
justify-content: center; justify-content: center;
align-items: center;
transform: scale(1.3);
/* Larger scale as requested */
transform-origin: center center;
flex-grow: 1;
/* Allow it to take space */
max-width: none;
/* Remove constraints */
} }
.fretboard-container svg { .fretboard-container svg {
height: 100%; height: 130px;
width: auto; width: auto;
max-width: 100%; max-width: 100%;
} }
/* Hide Instruction Text ("Play note above") */
.instruction-text {
display: none;
}
/* Move feedback and actions */ /* Move feedback and actions */
.feedback-area { .feedback-area {
width: 100%; width: 100%;
height: 30px; height: 30px;
order: 3; margin-top: 15px;
/* Force to bottom */ /* Increased from 10px */
margin-top: 5px; margin-bottom: 2px;
z-index: 20;
justify-content: center;
} }
.action-row { .action-row {
margin-top: 5px !important; margin-top: 5px !important;
order: 4; /* Increased slightly */
width: 100%; width: 100%;
padding-bottom: 4px;
}
/* Hide Zen Toggle in Landscape Mobile to prevent cutoff/clutter
User can rotate to portrait to access it or we move it.
For now, hiding it cleans up the view.
*/
/* Restore Zen Toggle in Landscape Mobile */
.exit-zen-button {
display: block;
transform: scale(0.8);
/* Scale down slightly */
bottom: 5px;
/* Stick to bottom */
right: 5px;
/* Stick to right */
padding: 6px 12px;
font-size: 0.8rem;
background: rgba(255, 255, 255, 0.9);
/* Opaque enough to see */
border: 1px solid #ccc;
z-index: 100;
}
.hint-button,
.skip-button {
padding: 4px 16px;
font-size: 0.9rem;
}
/* Pitch monitor: Keep visible but compact */
.pitch-monitor-bar {
display: flex;
margin-top: 2px;
gap: var(--spacing-sm);
transform: scale(0.7);
}
.mic-button {
width: 48px;
height: 48px;
}
.pitch-readout {
flex-direction: row;
gap: 8px;
align-items: baseline;
}
.detected-note {
font-size: 1.5rem;
} }
} }

View File

@@ -342,7 +342,7 @@ function App() {
)} )}
<main className="main-stage"> <main className="main-stage">
<div className={`card sheet-music-card ${settings.showHint ? 'has-hint' : ''}`}> <div className={`card sheet-music-card ${settings.showHint ? 'has-hint' : ''} ${settings.zenMode ? 'zen-mode' : ''}`}>
<div className="sheet-music-container"> <div className="sheet-music-container">
<SheetMusic <SheetMusic
targetMidi={targetMidi} targetMidi={targetMidi}
@@ -351,7 +351,7 @@ function App() {
clef={currentInstrumentDef.clefMode} clef={currentInstrumentDef.clefMode}
transpose={currentInstrumentDef.transpose} transpose={currentInstrumentDef.transpose}
width={Math.min(window.innerWidth - 40, 500)} width={Math.min(window.innerWidth - 40, 500)}
height={currentInstrumentDef.clefMode === 'grand' ? 300 : 250} height={currentInstrumentDef.clefMode === 'grand' ? 260 : 180}
hideTargetNote={settings.gameMode === 'ear_training' && !revealed} hideTargetNote={settings.gameMode === 'ear_training' && !revealed}
/> />
</div> </div>
@@ -383,7 +383,7 @@ function App() {
{settings.showHint && ( {settings.showHint && (
<div className="hint-card"> <div className="hint-card">
<div className="hint-note"> <div className="hint-note landscape-hint-note">
{getNoteDetails(targetMidi + currentInstrumentDef.transpose).scientific} {getNoteDetails(targetMidi + currentInstrumentDef.transpose).scientific}
</div> </div>
{currentInstrumentDef.showTuning && currentTuning && ( {currentInstrumentDef.showTuning && currentTuning && (

View File

@@ -56,12 +56,12 @@ export const SheetMusic: React.FC<SheetMusicProps> = ({
if (clef === 'grand') { if (clef === 'grand') {
// Create Treble Stave // Create Treble Stave
const topStave = new Stave(20, 40, width - 30); const topStave = new Stave(20, 20, width - 30);
topStave.addClef('treble').addKeySignature(keySignature); topStave.addClef('treble').addKeySignature(keySignature);
topStave.setContext(context).draw(); topStave.setContext(context).draw();
// Create Bass Stave // Create Bass Stave
const bottomStave = new Stave(20, 150, width - 30); const bottomStave = new Stave(20, 110, width - 30);
bottomStave.addClef('bass').addKeySignature(keySignature); bottomStave.addClef('bass').addKeySignature(keySignature);
bottomStave.setContext(context).draw(); bottomStave.setContext(context).draw();
@@ -82,7 +82,7 @@ export const SheetMusic: React.FC<SheetMusicProps> = ({
} else { } else {
// Single Stave // Single Stave
const stave = new Stave(10, 80, width - 20); // Centered vertically const stave = new Stave(10, 30, width - 20); // Centered vertically (tighter)
stave.addClef(clef).addKeySignature(keySignature); stave.addClef(clef).addKeySignature(keySignature);
stave.setContext(context).draw(); stave.setContext(context).draw();
// Map the single clef to the key matching the 'clef' prop so logic below works // Map the single clef to the key matching the 'clef' prop so logic below works