mirror of
https://github.com/9x/sheetmusictrainer.git
synced 2026-09-02 09:34:33 +02:00
piano details
This commit is contained in:
@@ -201,7 +201,7 @@ export function PianoKeys({
|
|||||||
|
|
||||||
// Styling
|
// Styling
|
||||||
let fill = k.isBlack ? '#222' : '#fff';
|
let fill = k.isBlack ? '#222' : '#fff';
|
||||||
if (interactive && isMarked) {
|
if (isMarked) {
|
||||||
fill = k.isBlack ? '#d32f2f' : '#ffcdd2'; // Red-ish for marked
|
fill = k.isBlack ? '#d32f2f' : '#ffcdd2'; // Red-ish for marked
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -223,21 +223,7 @@ export function PianoKeys({
|
|||||||
ry={k.isBlack ? 0 : 2}
|
ry={k.isBlack ? 0 : 2}
|
||||||
/>
|
/>
|
||||||
|
|
||||||
{isMarked && (
|
|
||||||
<circle
|
|
||||||
cx={k.x + (k.width / 2)}
|
|
||||||
cy={k.isBlack ? rectHeight - 10 : 80}
|
|
||||||
r={viewMode === 'full' ? 1.5 : 4} // This might still distort in circle shape if aspect ratio is wild?
|
|
||||||
// Circles in distorted SVG become ellipses.
|
|
||||||
// To verify: if viewMode is full, and we resize window...
|
|
||||||
// If we really want NO distortion, we should use non-scaling coordinate system.
|
|
||||||
// But let's try just fixing strokes first. Circles might be acceptable as ellipses or we fix them too.
|
|
||||||
// Actually, if we want perfect circles, we should not distort the SVG.
|
|
||||||
// But for now, user complained about "lines and labels".
|
|
||||||
fill="red"
|
|
||||||
vectorEffect="non-scaling-stroke"
|
|
||||||
/>
|
|
||||||
)}
|
|
||||||
</g>
|
</g>
|
||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
|||||||
@@ -42,7 +42,7 @@ export const SettingsModal: React.FC<SettingsModalProps> = ({ isOpen, onClose, s
|
|||||||
<div className="control-group" style={{ marginBottom: '24px' }}>
|
<div className="control-group" style={{ marginBottom: '24px' }}>
|
||||||
<div style={{ display: 'flex', alignItems: 'center', justifyContent: 'space-between', marginBottom: '8px' }}>
|
<div style={{ display: 'flex', alignItems: 'center', justifyContent: 'space-between', marginBottom: '8px' }}>
|
||||||
<label className="control-label" style={{ marginBottom: 0, fontSize: '16px' }}>
|
<label className="control-label" style={{ marginBottom: 0, fontSize: '16px' }}>
|
||||||
<span>Virtual Guitar Sound</span>
|
<span>Virtual Instrument Sound</span>
|
||||||
</label>
|
</label>
|
||||||
<button
|
<button
|
||||||
className={`switch-button ${!settings.virtualGuitarMute ? 'active' : ''}`}
|
className={`switch-button ${!settings.virtualGuitarMute ? 'active' : ''}`}
|
||||||
|
|||||||
Reference in New Issue
Block a user