mirror of
https://github.com/9x/sheetmusictrainer.git
synced 2026-11-03 13:53:55 +01:00
Compare commits
20 Commits
aebed68127
...
main
| Author | SHA1 | Date | |
|---|---|---|---|
| dfd8682500 | |||
| 751c3eec2f | |||
| cc75141430 | |||
| 206d4d63cc | |||
| 71271387ab | |||
| 56ace9efac | |||
| 05d5548d0c | |||
| 7a030f2728 | |||
| e43a17efb3 | |||
| c1f8f46cfe | |||
| ef96258e53 | |||
| baa66c0dc7 | |||
|
|
fe153a777a | ||
|
|
672cb341a7 | ||
|
|
75ad4613bb | ||
|
|
6b52a049e8 | ||
|
|
97a9a83f68 | ||
|
|
b4ba788d8e | ||
|
|
1ec1353c0b | ||
|
|
b7c8187aef |
@@ -1,5 +1,7 @@
|
||||
# Local deployment (nyx server) — beta channel
|
||||
- Managed by Nyx; deploy script: `~/deploy/smt-beta.sh [branch]` (fetch, build, docker rebuild, restart)
|
||||
- Container: `smt-beta` (nginx:alpine, 127.0.0.1:8081), image `smt-beta-image`
|
||||
- Tailnet URL: http://nyx-rg3jpx6w.internal.0jm.de/ (tailscale serve → 8081)
|
||||
# Local deployment (nyx server) — beta channel (tracks main = production state by default)
|
||||
- Managed by Nyx; deploy script: `~/deploy/smt-beta.sh [branch]` (fetch, build, docker rebuild, restart; **default branch: main**)
|
||||
- Container: `smt-beta` (nginx:alpine, 127.0.0.1:8081 **and** tailnet IP 100.64.0.4:8081), image `smt-beta-image`
|
||||
- Tailnet URLs:
|
||||
- http://nyx-rg3jpx6w.internal.0jm.de/ (tailscale serve → 8081; needs MagicDNS; Chrome history may autocomplete a broken https:// variant — delete it from history)
|
||||
- **http://100.64.0.4:8081/ (preferred: Chrome never HTTPS-upgrades IP:port URLs, no MagicDNS needed)**
|
||||
- Note: `tailscale serve --https` not available on this tailnet (feature not enabled); plain HTTP inside tailnet only
|
||||
|
||||
113
src/App.css
113
src/App.css
@@ -1040,30 +1040,54 @@ button {
|
||||
}
|
||||
|
||||
.phrase-setup {
|
||||
margin-top: 16px;
|
||||
border-top: 1px solid color-mix(in srgb, var(--color-text-main) 12%, transparent);
|
||||
padding-top: 12px;
|
||||
margin-bottom: 16px;
|
||||
border: 1px solid color-mix(in srgb, var(--color-text-main) 18%, transparent);
|
||||
border-radius: 10px;
|
||||
background: color-mix(in srgb, var(--color-text-main) 4%, transparent);
|
||||
}
|
||||
|
||||
.phrase-setup summary {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: 6px;
|
||||
gap: 8px;
|
||||
cursor: pointer;
|
||||
font-size: 13px;
|
||||
color: var(--color-text-muted);
|
||||
font-size: 15px;
|
||||
font-weight: 600;
|
||||
color: var(--color-text-main);
|
||||
padding: 12px 14px;
|
||||
user-select: none;
|
||||
list-style: none;
|
||||
border-radius: 10px;
|
||||
transition: background 0.15s ease;
|
||||
}
|
||||
|
||||
/* Hide the default disclosure triangle — the chevron icon does the job */
|
||||
.phrase-setup summary::-webkit-details-marker {
|
||||
display: none;
|
||||
}
|
||||
|
||||
.phrase-setup summary:hover {
|
||||
color: var(--color-text-main);
|
||||
background: color-mix(in srgb, var(--color-text-main) 7%, transparent);
|
||||
}
|
||||
|
||||
.phrase-setup[open] summary {
|
||||
border-bottom: 1px solid color-mix(in srgb, var(--color-text-main) 12%, transparent);
|
||||
border-radius: 10px 10px 0 0;
|
||||
}
|
||||
|
||||
.phrase-setup summary svg {
|
||||
transition: transform 0.15s ease;
|
||||
}
|
||||
|
||||
.phrase-setup[open] summary svg {
|
||||
transform: rotate(180deg);
|
||||
}
|
||||
|
||||
.phrase-setup-grid {
|
||||
display: grid;
|
||||
grid-template-columns: repeat(auto-fit, minmax(130px, 1fr));
|
||||
gap: 10px 14px;
|
||||
margin-top: 12px;
|
||||
padding: 12px 14px 14px;
|
||||
}
|
||||
|
||||
.phrase-setup-grid label {
|
||||
@@ -1126,3 +1150,76 @@ button {
|
||||
justify-content: safe center;
|
||||
justify-content: center;
|
||||
}
|
||||
|
||||
/* ---- Assist Mode ------------------------------------------------------- */
|
||||
/* Primitive practice companion: big detected note + live staff + optional
|
||||
fretboard with alternative positions. No trainer actions. */
|
||||
|
||||
.assist-card {
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
align-items: center;
|
||||
gap: var(--spacing-md);
|
||||
padding: var(--spacing-lg);
|
||||
}
|
||||
|
||||
.assist-note-area {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
justify-content: center;
|
||||
min-height: 110px;
|
||||
}
|
||||
|
||||
.assist-note-name {
|
||||
font-size: 5rem;
|
||||
font-weight: 800;
|
||||
line-height: 1;
|
||||
color: var(--color-text-main);
|
||||
font-variant-emoji: text;
|
||||
}
|
||||
|
||||
.assist-note-name.placeholder {
|
||||
color: var(--color-text-muted);
|
||||
opacity: 0.5;
|
||||
}
|
||||
|
||||
.assist-fretboard {
|
||||
width: 100%;
|
||||
display: flex;
|
||||
justify-content: center;
|
||||
overflow-x: auto;
|
||||
}
|
||||
|
||||
/* ---- Transport step group (preview stepping) ---------------------------- */
|
||||
.transport-step-group {
|
||||
display: flex;
|
||||
gap: 6px;
|
||||
}
|
||||
|
||||
.step-button {
|
||||
padding: 0.4rem 0.55rem;
|
||||
}
|
||||
|
||||
/* ---- Display toggles (virtual instrument / hint show-hide) -------------- */
|
||||
/* Separate row of pure show/hide switches, styled like the tuner and
|
||||
metronome switches — visually distinct from transport actions. */
|
||||
.display-toggles {
|
||||
display: flex;
|
||||
justify-content: center;
|
||||
gap: var(--spacing-lg);
|
||||
margin-top: 10px;
|
||||
}
|
||||
|
||||
.display-toggle {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: 8px;
|
||||
}
|
||||
|
||||
.display-toggle-label {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: 5px;
|
||||
font-size: 12px;
|
||||
color: var(--color-text-muted);
|
||||
}
|
||||
|
||||
93
src/App.tsx
93
src/App.tsx
@@ -8,6 +8,7 @@ import { SingleNoteTrainer, type SingleNoteHandle } from './components/SingleNot
|
||||
import { LiveNoteStaff } from './components/LiveNoteStaff';
|
||||
import { resolveClefTranspose } from './music/InstrumentConfigs';
|
||||
import { PhraseTrainer, type PhraseHandle } from './components/PhraseTrainer';
|
||||
import { AssistMode } from './components/AssistMode';
|
||||
import { usePitchDetector } from './hooks/usePitchDetector';
|
||||
import { useSettings } from './context/useSettings';
|
||||
import { audioEngine } from './audio/AudioEngine';
|
||||
@@ -26,6 +27,7 @@ function App() {
|
||||
const setSettings = updateSettings;
|
||||
|
||||
const isPhrase = settings.gameMode === 'phrase';
|
||||
const isAssist = settings.gameMode === 'assist';
|
||||
|
||||
const currentTuning = TUNINGS[settings.tuningId];
|
||||
const currentInstrumentDef = INSTRUMENT_DEFINITIONS[settings.instrument];
|
||||
@@ -121,24 +123,28 @@ function App() {
|
||||
useEffect(() => {
|
||||
const handleKeyDown = (e: KeyboardEvent) => {
|
||||
const target = e.target as HTMLElement | null;
|
||||
const onInteractive =
|
||||
// Text inputs / selects keep their native keys — shortcuts must not
|
||||
// fire while typing. FOCUSED BUTTONS however stay eligible: after a
|
||||
// click the button keeps focus, and gating there made N/R/P/L
|
||||
// silently dead until the user clicked elsewhere. Space/Enter on a
|
||||
// focused button activate it natively (guarded below), so no
|
||||
// double-fire.
|
||||
const onTextEntry =
|
||||
target instanceof HTMLInputElement ||
|
||||
target instanceof HTMLTextAreaElement ||
|
||||
target instanceof HTMLButtonElement ||
|
||||
target instanceof HTMLSelectElement ||
|
||||
!!target?.isContentEditable;
|
||||
if (onTextEntry) return;
|
||||
|
||||
if (e.code === 'Escape') {
|
||||
if (showHelp) setShowHelp(false);
|
||||
else if (settings.zenMode) setSettings(s => ({ ...s, zenMode: false }));
|
||||
return;
|
||||
}
|
||||
// Focused buttons handle their own keys (native activation);
|
||||
// global shortcuts must not double-fire or block them.
|
||||
if (onInteractive) return;
|
||||
|
||||
// Prevent default for space to stop scrolling
|
||||
if (e.code === 'Space') {
|
||||
// Prevent default for space to stop scrolling (Space on a focused
|
||||
// button activates it natively — preventDefault only applies when the
|
||||
// focus is on the body, where the shortcut below takes over).
|
||||
if (e.code === 'Space' && !(target instanceof HTMLButtonElement)) {
|
||||
e.preventDefault();
|
||||
}
|
||||
|
||||
@@ -159,6 +165,12 @@ function App() {
|
||||
case 'n':
|
||||
phraseRef.current?.next();
|
||||
break;
|
||||
case 'arrowleft':
|
||||
phraseRef.current?.previewStep(-1);
|
||||
break;
|
||||
case 'arrowright':
|
||||
phraseRef.current?.previewStep(1);
|
||||
break;
|
||||
case 's':
|
||||
phraseRef.current?.skip();
|
||||
break;
|
||||
@@ -169,12 +181,33 @@ function App() {
|
||||
setListening(l => !l);
|
||||
break;
|
||||
}
|
||||
if (e.code === 'Space' || e.code === 'Enter') {
|
||||
// Space/Enter on a focused button natively activate that button
|
||||
// (e.g. Start); only treat them as pause-toggle when NOT on a button.
|
||||
if ((e.code === 'Space' || e.code === 'Enter') && !(e.target instanceof HTMLButtonElement)) {
|
||||
phraseRef.current?.pauseToggle();
|
||||
}
|
||||
return;
|
||||
}
|
||||
|
||||
if (isAssist) {
|
||||
// Assist mode: only display shortcuts — no trainer actions.
|
||||
switch (e.key.toLowerCase()) {
|
||||
case 'h':
|
||||
setSettings(s => ({ ...s, showHint: !s.showHint }));
|
||||
break;
|
||||
case 'z':
|
||||
setSettings(s => ({ ...s, zenMode: !s.zenMode }));
|
||||
break;
|
||||
case 'v':
|
||||
setSettings(s => ({ ...s, showFretboard: !s.showFretboard }));
|
||||
break;
|
||||
case 'l':
|
||||
setListening(l => !l);
|
||||
break;
|
||||
}
|
||||
return;
|
||||
}
|
||||
|
||||
switch (e.key.toLowerCase()) {
|
||||
case 'h':
|
||||
setSettings(s => ({ ...s, showHint: !s.showHint }));
|
||||
@@ -200,23 +233,23 @@ function App() {
|
||||
break;
|
||||
}
|
||||
|
||||
if (e.code === 'Space' || e.code === 'Enter') {
|
||||
if ((e.code === 'Space' || e.code === 'Enter') && !(e.target instanceof HTMLButtonElement)) {
|
||||
singleNoteRef.current?.skipNote();
|
||||
}
|
||||
};
|
||||
|
||||
window.addEventListener('keydown', handleKeyDown);
|
||||
return () => window.removeEventListener('keydown', handleKeyDown);
|
||||
}, [settings, showHelp, isPhrase, setSettings]);
|
||||
}, [settings, showHelp, isPhrase, isAssist, setSettings]);
|
||||
|
||||
// 'm' cycles all three modes from phrase mode too.
|
||||
// 'm' cycles back to sight reading from phrase/assist modes.
|
||||
useEffect(() => {
|
||||
const handler = (e: KeyboardEvent) => {
|
||||
if (e.key.toLowerCase() !== 'm') return;
|
||||
const target = e.target as HTMLElement | null;
|
||||
if (target instanceof HTMLInputElement || target instanceof HTMLTextAreaElement ||
|
||||
target instanceof HTMLButtonElement || target instanceof HTMLSelectElement || target?.isContentEditable) return;
|
||||
if (settings.gameMode === 'phrase') {
|
||||
if (settings.gameMode === 'phrase' || settings.gameMode === 'assist') {
|
||||
setSettings(s => ({ ...s, gameMode: 'sight_reading' }));
|
||||
}
|
||||
};
|
||||
@@ -244,11 +277,19 @@ function App() {
|
||||
|
||||
<div className="header-controls">
|
||||
<div className="game-mode-toggle">
|
||||
<button
|
||||
className={`toggle-option ${settings.gameMode === 'assist' ? 'active' : ''}`}
|
||||
onClick={() => setSettings(s => ({ ...s, gameMode: 'assist' }))}
|
||||
title="Practice companion: shows played notes while you work from paper"
|
||||
>
|
||||
Assist
|
||||
</button>
|
||||
<button
|
||||
className={`toggle-option ${settings.gameMode === 'sight_reading' ? 'active' : ''}`}
|
||||
onClick={() => setSettings(s => ({ ...s, gameMode: 'sight_reading' }))}
|
||||
title="Learn to read notes from the staff"
|
||||
>
|
||||
Sight Reading
|
||||
Learn Notes
|
||||
</button>
|
||||
<button
|
||||
className={`toggle-option ${settings.gameMode === 'ear_training' ? 'active' : ''}`}
|
||||
@@ -305,6 +346,11 @@ function App() {
|
||||
micError={error}
|
||||
windowWidth={windowWidth}
|
||||
/>
|
||||
) : isAssist ? (
|
||||
<AssistMode
|
||||
pitchData={displayedPitch}
|
||||
windowWidth={windowWidth}
|
||||
/>
|
||||
) : (
|
||||
<SingleNoteTrainer
|
||||
ref={singleNoteRef}
|
||||
@@ -328,13 +374,17 @@ function App() {
|
||||
{listening ? <Mic size={28} /> : <MicOff size={28} />}
|
||||
</button>
|
||||
|
||||
<LiveNoteStaff
|
||||
midi={displayedPitch ? displayedPitch.midi : null}
|
||||
transpose={resolveClefTranspose(currentInstrumentDef, settings.difficulty).transpose}
|
||||
keySignature={settings.keySignature}
|
||||
clef={currentInstrumentDef.clefMode === 'treble' ? 'treble' : currentInstrumentDef.clefMode === 'bass' ? 'bass' : undefined}
|
||||
theme={settings.theme}
|
||||
/>
|
||||
{/* Live staff omitted in Assist mode: the Assist card already
|
||||
shows the played note large above the fretboard. */}
|
||||
{!isAssist && (
|
||||
<LiveNoteStaff
|
||||
midi={displayedPitch ? displayedPitch.midi : null}
|
||||
transpose={resolveClefTranspose(currentInstrumentDef, settings.difficulty).transpose}
|
||||
keySignature={settings.keySignature}
|
||||
clef={currentInstrumentDef.clefMode === 'treble' ? 'treble' : currentInstrumentDef.clefMode === 'bass' ? 'bass' : undefined}
|
||||
theme={settings.theme}
|
||||
/>
|
||||
)}
|
||||
<div className={`pitch-readout ${displayedPitch ? 'active' : ''}`}>
|
||||
{displayedPitch ? (
|
||||
<>
|
||||
@@ -391,6 +441,7 @@ function App() {
|
||||
<>
|
||||
<div className="help-item"><span>Start / Pause / Resume</span><span className="shortcut-key">Space</span></div>
|
||||
<div className="help-item"><span>Preview phrase (Play / Stop)</span><span className="shortcut-key">P</span></div>
|
||||
<div className="help-item"><span>While previewing: step note forward / back</span><span className="shortcut-key">→ / ←</span></div>
|
||||
<div className="help-item"><span>Retry phrase</span><span className="shortcut-key">R</span></div>
|
||||
<div className="help-item"><span>New melody / next bars</span><span className="shortcut-key">N</span></div>
|
||||
<div className="help-item"><span>Skip note (at your pace)</span><span className="shortcut-key">S</span></div>
|
||||
|
||||
102
src/components/AssistMode.tsx
Normal file
102
src/components/AssistMode.tsx
Normal file
@@ -0,0 +1,102 @@
|
||||
/**
|
||||
* Assist Mode — primitive practice companion for working from paper.
|
||||
*
|
||||
* No trainer, no scoring: shows the currently played (mic-detected) note
|
||||
* large, optionally with a live fretboard of alternative positions for that
|
||||
* note. Tuner and Metronome come from the shared footer tools (Controls),
|
||||
* so they stay identical across all modes.
|
||||
*/
|
||||
import { INSTRUMENT_DEFINITIONS, resolveClefTranspose } from '../music/InstrumentConfigs';
|
||||
import { useMemo } from 'react';
|
||||
import { useSettings } from '../context/useSettings';
|
||||
import { TUNINGS, getFretboardPositions } from '../music/Tunings';
|
||||
import { isFrettedInstrument } from '../music/playableRange';
|
||||
import { getPracticeFilter } from '../types/SettingsTypes';
|
||||
import { Fretboard } from './Fretboard';
|
||||
import { LiveNoteStaff } from './LiveNoteStaff';
|
||||
import type { PitchData } from '../hooks/usePitchDetector';
|
||||
|
||||
interface AssistModeProps {
|
||||
pitchData: PitchData | null;
|
||||
/** True while the app's own audio is audible (mic gate) — caller decides. */
|
||||
windowWidth: number;
|
||||
}
|
||||
|
||||
export const AssistMode: React.FC<AssistModeProps> = ({ pitchData, windowWidth }) => {
|
||||
const { settings } = useSettings();
|
||||
const currentTuning = TUNINGS[settings.tuningId];
|
||||
const currentInstrumentDef = INSTRUMENT_DEFINITIONS[settings.instrument];
|
||||
|
||||
const fretted = isFrettedInstrument(settings.instrument) && !!currentTuning;
|
||||
const pf = getPracticeFilter(settings);
|
||||
|
||||
const { clef, transpose } = useMemo(() =>
|
||||
resolveClefTranspose(currentInstrumentDef, settings.difficulty),
|
||||
[currentInstrumentDef, settings.difficulty]);
|
||||
|
||||
// Alternative positions for the detected note (respect fret window filter)
|
||||
const positions = useMemo(() => {
|
||||
if (!fretted || !currentTuning || !pitchData) return [];
|
||||
const all = getFretboardPositions(pitchData.midi, currentTuning, 20);
|
||||
if (!pf.fretWindowEnabled) return all;
|
||||
return all.filter(p => p.fret >= Math.max(0, pf.fretMin) && p.fret <= Math.min(24, pf.fretMax));
|
||||
}, [fretted, currentTuning, pitchData, pf.fretWindowEnabled, pf.fretMin, pf.fretMax]);
|
||||
|
||||
// Full written range of the currently configured pool (strings × frets,
|
||||
// respecting the same filter as the position markers). The staff box is
|
||||
// sized to fit it, so notes render at their TRUE written position with
|
||||
// real ledger lines — no 8va/8vb octave shifting.
|
||||
const range = useMemo(() => {
|
||||
if (!fretted || !currentTuning) return undefined;
|
||||
const strings = pf.strings.length > 0
|
||||
? currentTuning.strings.filter((_, i) => pf.strings.includes(i))
|
||||
: currentTuning.strings;
|
||||
if (strings.length === 0) return undefined;
|
||||
const lo = pf.fretWindowEnabled ? Math.max(0, pf.fretMin) : 0;
|
||||
const hi = pf.fretWindowEnabled ? Math.min(24, pf.fretMax) : 24;
|
||||
return {
|
||||
min: Math.min(...strings) + lo + transpose,
|
||||
max: Math.max(...strings) + hi + transpose,
|
||||
};
|
||||
}, [fretted, currentTuning, pf.strings, pf.fretWindowEnabled, pf.fretMin, pf.fretMax, transpose]);
|
||||
|
||||
const staffWidth = Math.min(windowWidth - 40, 860);
|
||||
|
||||
return (
|
||||
<div className="card sheet-music-card assist-card">
|
||||
<div className="assist-note-area">
|
||||
{pitchData ? (
|
||||
<span className="assist-note-name">{pitchData.note}</span>
|
||||
) : (
|
||||
<span className="assist-note-name placeholder">—</span>
|
||||
)}
|
||||
</div>
|
||||
|
||||
<div className="sheet-music-container">
|
||||
<LiveNoteStaff
|
||||
midi={pitchData ? pitchData.midi : null}
|
||||
transpose={transpose}
|
||||
keySignature={settings.keySignature}
|
||||
clef={clef === 'grand' ? undefined : clef}
|
||||
width={Math.min(240, staffWidth)}
|
||||
height={88}
|
||||
range={range}
|
||||
theme={settings.theme}
|
||||
/>
|
||||
</div>
|
||||
|
||||
{fretted && currentTuning && (
|
||||
<div className="assist-fretboard">
|
||||
<Fretboard
|
||||
tuning={currentTuning}
|
||||
positions={positions}
|
||||
maxFrets={15}
|
||||
showHints={true}
|
||||
interactive={false}
|
||||
displayTranspose={transpose}
|
||||
/>
|
||||
</div>
|
||||
)}
|
||||
</div>
|
||||
);
|
||||
};
|
||||
@@ -1,14 +1,11 @@
|
||||
import React, { useEffect, useState } from 'react';
|
||||
import { Guitar, Music, Gauge } from 'lucide-react';
|
||||
import { TUNINGS, INSTRUMENT_TUNINGS } from '../music/Tunings';
|
||||
import { INSTRUMENT_DEFINITIONS } from '../music/InstrumentConfigs';
|
||||
|
||||
import { Gauge, SlidersHorizontal } from 'lucide-react';
|
||||
import { TuningMeter } from './TuningMeter';
|
||||
import { TargetNoteControls } from './TargetNoteControls';
|
||||
import { MetronomeWidget } from './MetronomeWidget';
|
||||
import { phraseRunBus } from '../hooks/phraseRunBus';
|
||||
import { useSettings } from '../context/useSettings';
|
||||
import { type Difficulty, type RhythmSettings } from '../types/SettingsTypes';
|
||||
import { getPracticeFilter, type RhythmSettings } from '../types/SettingsTypes';
|
||||
|
||||
|
||||
|
||||
@@ -18,35 +15,13 @@ interface ControlsProps {
|
||||
|
||||
export const Controls: React.FC<ControlsProps> = ({ currentPitch }) => {
|
||||
const { settings, updateSettings } = useSettings();
|
||||
// Alias to minimize refactor, or just use updateSettings.
|
||||
const onUpdateSettings = updateSettings;
|
||||
// Phrase run gate: the metronome only ticks while the phrase trainer is
|
||||
// counting in / playing (armed by the user toggle, fired by the run).
|
||||
const [phraseRunActive, setPhraseRunActive] = useState(false);
|
||||
useEffect(() => phraseRunBus.subscribe(setPhraseRunActive), []);
|
||||
const handleTuningChange = (e: React.ChangeEvent<HTMLSelectElement>) => {
|
||||
onUpdateSettings({ ...settings, tuningId: e.target.value });
|
||||
};
|
||||
|
||||
const handleInstrumentChange = (e: React.ChangeEvent<HTMLSelectElement>) => {
|
||||
const newInstrumentId = e.target.value;
|
||||
const instDef = INSTRUMENT_DEFINITIONS[newInstrumentId];
|
||||
|
||||
const defaultRange = instDef.ranges[0].id;
|
||||
|
||||
// Reset tuning if applicable, or just keep as is (it won't be shown/used)
|
||||
let newTuningId = settings.tuningId;
|
||||
if (instDef.showTuning && INSTRUMENT_TUNINGS[newInstrumentId as 'guitar' | 'bass']) {
|
||||
newTuningId = INSTRUMENT_TUNINGS[newInstrumentId as 'guitar' | 'bass'][0];
|
||||
}
|
||||
|
||||
onUpdateSettings({
|
||||
...settings,
|
||||
instrument: newInstrumentId,
|
||||
difficulty: defaultRange as Difficulty,
|
||||
tuningId: newTuningId
|
||||
});
|
||||
};
|
||||
// Note-filter panel: hidden by default (minimal UI), toggled here.
|
||||
const [filtersOpen, setFiltersOpen] = useState(false);
|
||||
|
||||
const updateRhythm = (updates: Partial<RhythmSettings>) => {
|
||||
onUpdateSettings({
|
||||
@@ -55,101 +30,46 @@ export const Controls: React.FC<ControlsProps> = ({ currentPitch }) => {
|
||||
});
|
||||
};
|
||||
|
||||
// Cast instrument to specific key if needed, or use generic record access
|
||||
const availableTunings = INSTRUMENT_TUNINGS[settings.instrument as 'guitar' | 'bass'] || [];
|
||||
const currentInstrumentDef = INSTRUMENT_DEFINITIONS[settings.instrument];
|
||||
|
||||
|
||||
|
||||
// Phrase Mode brings its own key/tempo machinery; the single-note
|
||||
// key-signature select and metronome tool would be competing controls.
|
||||
const inPhraseMode = settings.gameMode === 'phrase';
|
||||
|
||||
const pf = getPracticeFilter(settings);
|
||||
const activeFilterCount =
|
||||
(pf.keyEnabled ? 1 : 0) +
|
||||
(pf.strings.length > 0 ? 1 : 0) +
|
||||
(pf.fretWindowEnabled ? 1 : 0);
|
||||
|
||||
// Phrase Mode hosts the filter inside its Setup panel (above the
|
||||
// notation) — no footer filter button there.
|
||||
const showFilterButton = !inPhraseMode;
|
||||
const shouldShowFilters = showFilterButton && filtersOpen;
|
||||
|
||||
return (
|
||||
<div className="controls-container">
|
||||
{/* Top Section: Settings Grid (2 Columns) */}
|
||||
<div className="settings-grid">
|
||||
{/* Row 1, Col 1 */}
|
||||
<div className="control-group">
|
||||
<label className="control-label">
|
||||
<Music size={18} />
|
||||
<span>Instrument</span>
|
||||
</label>
|
||||
<select
|
||||
value={settings.instrument}
|
||||
onChange={handleInstrumentChange}
|
||||
className="control-select"
|
||||
>
|
||||
{Object.values(INSTRUMENT_DEFINITIONS).map(def => (
|
||||
<option key={def.id} value={def.id}>{def.displayName}</option>
|
||||
))}
|
||||
</select>
|
||||
</div>
|
||||
|
||||
{/* Row 1, Col 2 (Conditional) */}
|
||||
{currentInstrumentDef.showTuning ? (
|
||||
<div className="control-group">
|
||||
<label className="control-label">
|
||||
<Guitar size={18} />
|
||||
<span>Tuning</span>
|
||||
</label>
|
||||
<select
|
||||
value={settings.tuningId}
|
||||
onChange={handleTuningChange}
|
||||
className="control-select"
|
||||
>
|
||||
{availableTunings.map(id => (
|
||||
<option key={id} value={id}>{TUNINGS[id].name}</option>
|
||||
))}
|
||||
</select>
|
||||
</div>
|
||||
) : <div />} {/* Spacer to maintain grid flow if needed, or omit to let items flow. User asked for specific rows.
|
||||
If I omit, Note Set goes here. Let's omit for "Dense" feel, or keep empty div for strict rows?
|
||||
The request "Top row: instrument and tuning" implies if tuning is missing, maybe just 1 item?
|
||||
I'll output an empty div if I want to FORCE strict placement, but generally flow is better.
|
||||
However, "Second row: note set..." suggests structure.
|
||||
I will use an empty div if tuning is hidden to push Note Set to next row?
|
||||
Actually, grid-template-columns: 1fr 1fr.
|
||||
If Tuning is hidden, Note Set becomes Item 2.
|
||||
I'll forgo complexity and just render what's available. */}
|
||||
|
||||
{/* Row 2, Col 2 */}
|
||||
{!inPhraseMode && (
|
||||
<div className="control-group">
|
||||
<label className="control-label">
|
||||
<span>Key signature</span>
|
||||
</label>
|
||||
<select
|
||||
value={settings.keySignature}
|
||||
onChange={(e) => onUpdateSettings({ ...settings, keySignature: e.target.value })}
|
||||
className="control-select"
|
||||
>
|
||||
<optgroup label="Major Keys">
|
||||
<option value="C">C Major</option>
|
||||
<option value="G">G Major</option>
|
||||
<option value="D">D Major</option>
|
||||
<option value="A">A Major</option>
|
||||
<option value="E">E Major</option>
|
||||
<option value="F">F Major</option>
|
||||
<option value="Bb">Bb Major</option>
|
||||
<option value="Eb">Eb Major</option>
|
||||
</optgroup>
|
||||
<optgroup label="Minor Keys">
|
||||
<option value="Am">A Minor</option>
|
||||
<option value="Em">E Minor</option>
|
||||
<option value="Dm">D Minor</option>
|
||||
</optgroup>
|
||||
</select>
|
||||
</div>
|
||||
)}
|
||||
|
||||
{/* Note filter: collapsed behind a button — visible only when needed */}
|
||||
{showFilterButton && (
|
||||
<div style={{ display: 'flex', justifyContent: 'center', marginBottom: '8px' }}>
|
||||
<button
|
||||
className={`hint-button ${filtersOpen ? 'active' : ''}`}
|
||||
onClick={() => setFiltersOpen(o => !o)}
|
||||
title="Limit the notes used for exercises (key, strings, fret window)"
|
||||
>
|
||||
<SlidersHorizontal size={16} />
|
||||
Filter
|
||||
{activeFilterCount > 0 && (
|
||||
<span style={{
|
||||
display: 'inline-block', minWidth: '18px', padding: '1px 5px',
|
||||
marginLeft: '4px', borderRadius: '9px', fontSize: '11px',
|
||||
background: 'var(--color-primary)', color: 'var(--color-surface)',
|
||||
fontWeight: 600, textAlign: 'center'
|
||||
}}>{activeFilterCount}</span>
|
||||
)}
|
||||
</button>
|
||||
</div>
|
||||
)}
|
||||
{shouldShowFilters && <TargetNoteControls />}
|
||||
|
||||
{/* Target-note filter: unified controls, all modes */}
|
||||
<TargetNoteControls />
|
||||
|
||||
{/* Bottom Section: Tools Grid (2 Columns now) */}
|
||||
<div className="tools-grid" style={inPhraseMode ? { gridTemplateColumns: '1fr' } : undefined}>
|
||||
{/* Bottom Section: Tools Grid (stacked in all modes) */}
|
||||
<div className="tools-grid" style={{ gridTemplateColumns: '1fr' }}>
|
||||
{/* Tool 1: Tuner */}
|
||||
<div style={{ display: 'flex', flexDirection: 'column', gap: '8px', border: '1px solid rgba(128,128,128,0.2)', padding: '12px', borderRadius: '8px' }}>
|
||||
<div style={{ display: 'flex', alignItems: 'center', justifyContent: 'space-between' }}>
|
||||
@@ -166,7 +86,7 @@ export const Controls: React.FC<ControlsProps> = ({ currentPitch }) => {
|
||||
</button>
|
||||
</div>
|
||||
{settings.showTuningMeter && (
|
||||
<div style={{ paddingTop: '8px', borderTop: '1px solid color-mix(in srgb, var(--color-text-main) 10%, transparent)' }}>
|
||||
<div style={{ paddingTop: '8px', borderTop: '1px solid color-mix(in srgb, var(--color-text-main) 10%, transparent)', display: 'flex', justifyContent: 'center' }}>
|
||||
<TuningMeter
|
||||
cents={currentPitch ? currentPitch.cents : null}
|
||||
noteName={currentPitch ? currentPitch.note : null}
|
||||
|
||||
@@ -21,14 +21,45 @@ interface LiveNoteStaffProps {
|
||||
* clef auto-switches treble/bass around middle C (piano-style). */
|
||||
clef?: 'treble' | 'bass';
|
||||
width?: number;
|
||||
/** Box height. 64px matches the mic bar; larger boxes (e.g. 88px in
|
||||
* Assist mode) give ledger lines room inside instead of being clipped
|
||||
* by the parent's overflow: hidden. Ignored when `range` is set. */
|
||||
height?: number;
|
||||
/** Written-pitch range the box must fit WITHOUT octave shifting.
|
||||
* When set, notes render at their true staff position with real ledger
|
||||
* lines (no 8va/8vb marker) and the box height is computed from the
|
||||
* range so every note in it stays inside the box. */
|
||||
range?: { min: number; max: number };
|
||||
theme?: 'light' | 'dark' | 'auto';
|
||||
}
|
||||
|
||||
const BOX_H = 64; // mic button height — vertical centering via the bar
|
||||
// VexFlow draws the first stave line ~40.5px BELOW the constructor y
|
||||
// (default space_above_staff_ln = 4 line-spaces). To center a 38px staff in
|
||||
// the 64px box the constructor y must be negative.
|
||||
const STAVE_Y = -28;
|
||||
// (default space_above_staff_ln = 4 line-spaces). To center the ~38px staff
|
||||
// in a box of height h the constructor y must be negative. For h = 64 this
|
||||
// yields -27.5 ≈ -28 (the original hardcoded value).
|
||||
const staveYFor = (h: number) => (h - 38) / 2 - 40.5;
|
||||
|
||||
// Diatonic index (C0 = 0, one step per letter name) for ledger-line math.
|
||||
const DI_STEP = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11];
|
||||
const diFromMidi = (m: number) => Math.floor(m / 12 - 1) * 7 + DI_STEP[m % 12];
|
||||
// Top/bottom staff-line diatonic index per clef (treble F5/E4, bass A3/G2).
|
||||
const CLEF_LINES: Record<'treble' | 'bass', { top: number; bottom: number }> = {
|
||||
treble: { top: 38, bottom: 30 },
|
||||
bass: { top: 26, bottom: 18 },
|
||||
};
|
||||
// One diatonic step = half a staff space = 5px (standard 10px spaces).
|
||||
// Box that fits a whole written range: staff anchored below the top
|
||||
// headroom so the highest note has room for its ledger lines, lowest note
|
||||
// the same at the bottom.
|
||||
const rangeLayout = (range: { min: number; max: number }, clef: 'treble' | 'bass') => {
|
||||
const lines = CLEF_LINES[clef];
|
||||
const aboveLines = Math.max(0, Math.ceil((diFromMidi(range.max) - lines.top) / 2));
|
||||
const belowLines = Math.max(0, Math.ceil((lines.bottom - diFromMidi(range.min)) / 2));
|
||||
const abovePx = aboveLines * 10 + 10; // + notehead margin
|
||||
const belowPx = belowLines * 10 + 10;
|
||||
return { height: abovePx + 38 + belowPx, y: abovePx - 40.5 };
|
||||
};
|
||||
|
||||
export const LiveNoteStaff: React.FC<LiveNoteStaffProps> = ({
|
||||
midi,
|
||||
@@ -36,9 +67,18 @@ export const LiveNoteStaff: React.FC<LiveNoteStaffProps> = ({
|
||||
keySignature = 'C',
|
||||
clef: clefOverride,
|
||||
width = 130,
|
||||
height = BOX_H,
|
||||
range,
|
||||
theme = 'auto',
|
||||
}) => {
|
||||
const containerRef = useRef<HTMLDivElement>(null);
|
||||
|
||||
// Box geometry: range-fit wins over the fixed height prop.
|
||||
const fit = range
|
||||
? rangeLayout(range, clefOverride ?? 'treble')
|
||||
: { height, y: staveYFor(height) };
|
||||
const boxH = fit.height;
|
||||
const staveY = fit.y;
|
||||
const [schemeVersion, setSchemeVersion] = useState(0);
|
||||
useEffect(() => {
|
||||
const mq = window.matchMedia('(prefers-color-scheme: dark)');
|
||||
@@ -53,7 +93,7 @@ export const LiveNoteStaff: React.FC<LiveNoteStaffProps> = ({
|
||||
container.innerHTML = '';
|
||||
|
||||
const renderer = new Renderer(container, Renderer.Backends.SVG);
|
||||
renderer.resize(width, BOX_H);
|
||||
renderer.resize(width, boxH);
|
||||
const context = renderer.getContext();
|
||||
|
||||
const resolvedColor =
|
||||
@@ -63,7 +103,7 @@ export const LiveNoteStaff: React.FC<LiveNoteStaffProps> = ({
|
||||
context.setFillStyle(resolvedColor);
|
||||
context.setStrokeStyle(resolvedColor);
|
||||
|
||||
const stave = new Stave(0, STAVE_Y, width - 2);
|
||||
const stave = new Stave(0, staveY, width - 2);
|
||||
stave.setDefaultLedgerLineStyle({ strokeStyle: resolvedColor, lineWidth: 2 });
|
||||
const written0 = midi !== null ? midi + transpose : null;
|
||||
// Instrument-fixed clef when provided (guitar always treble, bass
|
||||
@@ -79,13 +119,17 @@ export const LiveNoteStaff: React.FC<LiveNoteStaffProps> = ({
|
||||
// treble: staff E4..F5 (+ up to two ledger lines each way)
|
||||
// bass: staff G2..A3 (+ up to two ledger lines each way)
|
||||
let written = written0!;
|
||||
// Range-fit mode renders the TRUE written position with real
|
||||
// ledger lines — no 8va/8vb shifting.
|
||||
let octaveMark: '8va' | '8vb' | null = null;
|
||||
if (clef === 'treble') {
|
||||
while (written < 58) { written += 12; octaveMark = '8vb'; }
|
||||
while (written > 81) { written -= 12; octaveMark = '8va'; }
|
||||
} else {
|
||||
while (written < 40) { written += 12; octaveMark = '8vb'; }
|
||||
while (written > 61) { written -= 12; octaveMark = '8va'; }
|
||||
if (!range) {
|
||||
if (clef === 'treble') {
|
||||
while (written < 58) { written += 12; octaveMark = '8vb'; }
|
||||
while (written > 81) { written -= 12; octaveMark = '8va'; }
|
||||
} else {
|
||||
while (written < 40) { written += 12; octaveMark = '8vb'; }
|
||||
while (written > 61) { written -= 12; octaveMark = '8va'; }
|
||||
}
|
||||
}
|
||||
|
||||
const spec = getNoteInKey(written, keySignature);
|
||||
@@ -113,13 +157,13 @@ export const LiveNoteStaff: React.FC<LiveNoteStaffProps> = ({
|
||||
new Formatter().joinVoices([voice]).format([voice], width - 40);
|
||||
voice.draw(context, stave);
|
||||
}
|
||||
}, [midi, transpose, keySignature, clefOverride, width, theme, schemeVersion]);
|
||||
}, [midi, transpose, keySignature, clefOverride, width, boxH, staveY, range, theme, schemeVersion]);
|
||||
|
||||
return (
|
||||
<div
|
||||
ref={containerRef}
|
||||
className="live-note-staff"
|
||||
style={{ width, height: BOX_H }}
|
||||
style={{ width, height: boxH }}
|
||||
role="img"
|
||||
aria-label={midi !== null ? 'Currently played note' : 'No note currently detected'}
|
||||
/>
|
||||
|
||||
@@ -55,13 +55,22 @@ export const MetronomeWidget: React.FC<MetronomeWidgetProps> = ({
|
||||
|
||||
const isSync = syncMode === 'option' && !!rhythm.syncToExercise;
|
||||
const runActive = gate === true;
|
||||
// Phrase mode (syncMode 'option') has no on/off switch — the sync
|
||||
// checkbox replaces it (unchecked = free metronome, checked = synced to
|
||||
// the exercise), so the metronome is always armed there. Gating on
|
||||
// rhythm.active would leave phrase users with no way to enable clicks.
|
||||
const armed = syncMode === 'option' ? true : rhythm.active;
|
||||
// Sync: pendulum/click only while the run is active (the run's scheduler
|
||||
// is the click source; the widget's own scheduler stays off).
|
||||
// Free/plain: the widget's own scheduler runs whenever armed.
|
||||
const running = isSync ? runActive : rhythm.active;
|
||||
const running = isSync ? runActive : armed;
|
||||
|
||||
// Timer mode = one beat per N seconds: effective BPM 60/seconds so
|
||||
// clicks and pendulum match the trainer's auto-advance cadence.
|
||||
const effectiveBpm = rhythm.mode === 'bpm' ? rhythm.bpm : 60 / Math.max(1, rhythm.seconds);
|
||||
|
||||
const { restart } = useMetronome({
|
||||
bpm: rhythm.bpm,
|
||||
bpm: effectiveBpm,
|
||||
volume: rhythm.sound ? rhythm.volume : 0,
|
||||
playing: running && !isSync,
|
||||
onTick: handleTick,
|
||||
@@ -77,8 +86,7 @@ export const MetronomeWidget: React.FC<MetronomeWidgetProps> = ({
|
||||
});
|
||||
}, [isSync, runActive]);
|
||||
|
||||
const beatMs = 60000 / Math.max(1, rhythm.bpm);
|
||||
const armed = rhythm.active;
|
||||
const beatMs = 60000 / Math.max(1, effectiveBpm);
|
||||
|
||||
return (
|
||||
<div style={{ display: 'flex', flexDirection: 'column', gap: '8px' }}>
|
||||
|
||||
@@ -13,7 +13,7 @@ import { forwardRef, useCallback, useEffect, useImperativeHandle, useMemo, useRe
|
||||
import { useSettings } from '../context/useSettings';
|
||||
import { useAudioPlayer } from '../hooks/useAudioPlayer';
|
||||
import { usePhraseTrainer, type PhraseTrainerApi, type PhrasePhase } from '../hooks/usePhraseTrainer';
|
||||
import { getPhraseSettings, getPracticeFilter, type PhraseSettings, type PracticeFilter } from '../types/SettingsTypes';
|
||||
import { getPhraseSettings, getPracticeFilter, type PhraseSettings } from '../types/SettingsTypes';
|
||||
import { rawFrameCount } from '../hooks/rawFrameBus';
|
||||
import { audioEngine } from '../audio/AudioEngine';
|
||||
import { computePlayableNotes, isFrettedInstrument, positionsWithinWindow } from '../music/playableRange';
|
||||
@@ -28,17 +28,19 @@ import { getNoteDetails } from '../music/NoteUtils';
|
||||
import { EXERCISES, loadExercise } from '../exercises/library';
|
||||
import { parseAbc } from '../exercises/abcParser';
|
||||
import { PhraseSheetMusic } from './PhraseSheetMusic';
|
||||
import { TargetNoteControls } from './TargetNoteControls';
|
||||
import { Fretboard } from './Fretboard';
|
||||
import { PianoKeys } from './PianoKeys';
|
||||
import { TUNINGS, getFretboardPositions } from '../music/Tunings';
|
||||
import { INSTRUMENT_DEFINITIONS, resolveClefTranspose } from '../music/InstrumentConfigs';
|
||||
const AUTO_CONTINUE_DELAY_MS = 1500;
|
||||
|
||||
import { Play, Pause, RotateCcw, SkipForward, Volume2, Square, ChevronDown, Music2, Upload, HelpCircle, Guitar } from 'lucide-react';
|
||||
import { Play, Pause, RotateCcw, SkipForward, SkipBack, Volume2, ChevronDown, Music2, Upload, HelpCircle, Guitar } from 'lucide-react';
|
||||
|
||||
export interface PhraseHandle {
|
||||
pauseToggle: () => void;
|
||||
previewToggle: () => void;
|
||||
previewStep: (dir: 1 | -1) => void;
|
||||
retry: () => void;
|
||||
skip: () => void;
|
||||
next: () => void;
|
||||
@@ -71,14 +73,9 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
const setSettings = updateSettings;
|
||||
const { playNote } = useAudioPlayer();
|
||||
const phrase = getPhraseSettings(settings);
|
||||
// Unified target-note controls: Phrase Mode reads/writes the shared
|
||||
// practice filter so all modes expose identical key/fret-window state.
|
||||
// Unified target-note controls: Phrase Mode reads the shared practice
|
||||
// filter (single source of truth across all modes).
|
||||
const pf = getPracticeFilter(settings);
|
||||
phrase.keyTonic = pf.keyTonic;
|
||||
phrase.keyMode = pf.keyMode;
|
||||
phrase.fretWindowEnabled = pf.fretWindowEnabled;
|
||||
phrase.fretMin = pf.fretMin;
|
||||
phrase.fretMax = pf.fretMax;
|
||||
// Unified metronome: phrase tempo reads from the shared rhythm BPM
|
||||
// (single source of truth across modes; the phrase-local BPM control
|
||||
// was replaced by the common metronome widget in Controls).
|
||||
@@ -88,26 +85,17 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
const pace: PhraseSettings['pace'] = settings.rhythm.syncToExercise ? 'tempo' : 'step';
|
||||
phrase.pace = pace;
|
||||
// Click decision — ONE source: the metronome widget's sound checkbox.
|
||||
// - Sync (tempo): run clicks when armed && sound (count-in incl.);
|
||||
// widget silent while idle.
|
||||
// - Free metronome: widget clicks freely; the run stays silent to
|
||||
// avoid doubling (sync off in tempo = free widget during runs).
|
||||
phrase.clickSound = pace === 'tempo'
|
||||
? settings.rhythm.active && settings.rhythm.sound
|
||||
: settings.rhythm.active && settings.rhythm.sound && !settings.rhythm.syncToExercise;
|
||||
// Phrase mode has no metronome on/off switch (the sync checkbox
|
||||
// replaces it, see MetronomeWidget), so rhythm.active must NOT gate
|
||||
// clicks here — with the default active:false a synced run would
|
||||
// stay silent with no way to fix it from this mode.
|
||||
// - Sync (tempo): run clicks when sound is on (count-in included);
|
||||
// the widget stays silent while idle.
|
||||
// - Free metronome (step): the widget clicks freely; the run stays
|
||||
// silent to avoid doubling.
|
||||
phrase.clickSound = settings.rhythm.sound;
|
||||
const setPhrase = useCallback((updates: Partial<PhraseSettings>) => {
|
||||
updateSettings(s => {
|
||||
const next = { ...s, phrase: { ...getPhraseSettings(s), ...updates } };
|
||||
// Mirror shared filter fields into the unified practice filter.
|
||||
const shared: Partial<PracticeFilter> = {};
|
||||
if ('keyTonic' in updates) shared.keyTonic = updates.keyTonic;
|
||||
if ('keyMode' in updates) shared.keyMode = updates.keyMode;
|
||||
if ('fretWindowEnabled' in updates) shared.fretWindowEnabled = updates.fretWindowEnabled;
|
||||
if ('fretMin' in updates) shared.fretMin = updates.fretMin;
|
||||
if ('fretMax' in updates) shared.fretMax = updates.fretMax;
|
||||
if (Object.keys(shared).length > 0) next.practice = { ...getPracticeFilter(s), ...shared };
|
||||
return next;
|
||||
});
|
||||
updateSettings(s => ({ ...s, phrase: { ...getPhraseSettings(s), ...updates } }));
|
||||
}, [updateSettings]);
|
||||
const currentInstrumentDef = INSTRUMENT_DEFINITIONS[settings.instrument];
|
||||
const currentTuning = TUNINGS[settings.tuningId];
|
||||
@@ -140,7 +128,6 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
customMaxFret: settings.customMaxFret,
|
||||
});
|
||||
}, [pf.strings, pf.fretWindowEnabled, pf.fretMin, pf.fretMax, fretted, currentTuning,
|
||||
phrase.fretWindowEnabled, phrase.fretMin, phrase.fretMax,
|
||||
settings.instrument, settings.difficulty, settings.tuningId, settings.customMinFret, settings.customMaxFret]);
|
||||
|
||||
// ---- Imported score (session-only) --------------------------------------
|
||||
@@ -173,8 +160,8 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
const baseScore: Result<Score> | null = useMemo(() => {
|
||||
if (phrase.material === 'melody') {
|
||||
const result = generateMelody({
|
||||
keyTonic: phrase.keyTonic,
|
||||
keyMode: (isMode(phrase.keyMode) ? phrase.keyMode : 'major') as ModeId,
|
||||
keyTonic: pf.keyTonic,
|
||||
keyMode: (isMode(pf.keyMode) ? pf.keyMode : 'major') as ModeId,
|
||||
bars: phrase.bars,
|
||||
meter: { numerator: phrase.meterNumerator, denominator: 4 },
|
||||
rhythmLevel: phrase.rhythmLevel,
|
||||
@@ -184,8 +171,8 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
}
|
||||
if (phrase.material === 'scale') {
|
||||
return generateScaleDrill({
|
||||
keyTonic: phrase.keyTonic,
|
||||
keyMode: (isMode(phrase.keyMode) ? phrase.keyMode : 'major') as ModeId,
|
||||
keyTonic: pf.keyTonic,
|
||||
keyMode: (isMode(pf.keyMode) ? pf.keyMode : 'major') as ModeId,
|
||||
direction: phrase.scaleDirection,
|
||||
coverage: phrase.scaleCoverage,
|
||||
meter: { numerator: phrase.meterNumerator, denominator: 4 },
|
||||
@@ -196,8 +183,8 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
// Meter is auto-derived inside the generator from the figure
|
||||
// length (always eighths) — the user no longer picks a meter.
|
||||
return generateGiulianiStudy({
|
||||
keyTonic: phrase.keyTonic,
|
||||
keyMode: (isMode(phrase.keyMode) ? phrase.keyMode : 'major') as ModeId,
|
||||
keyTonic: pf.keyTonic,
|
||||
keyMode: (isMode(pf.keyMode) ? pf.keyMode : 'major') as ModeId,
|
||||
pattern: phrase.giulianiPattern,
|
||||
tuningId: settings.tuningId,
|
||||
bars: phrase.giulianiBars,
|
||||
@@ -209,8 +196,8 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
}
|
||||
if (phrase.material === 'arpeggio') {
|
||||
return generateArpeggio({
|
||||
keyTonic: phrase.keyTonic,
|
||||
keyMode: (isMode(phrase.keyMode) ? phrase.keyMode : 'major') as ModeId,
|
||||
keyTonic: pf.keyTonic,
|
||||
keyMode: (isMode(pf.keyMode) ? pf.keyMode : 'major') as ModeId,
|
||||
degree: (phrase.arpeggioDegree as ArpeggioDegree) || 'I',
|
||||
pattern: phrase.arpeggioPattern,
|
||||
coverage: phrase.arpeggioCoverage,
|
||||
@@ -231,7 +218,7 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
return { ok: true, value: importedScore };
|
||||
}
|
||||
return null;
|
||||
}, [phrase.material, phrase.keyTonic, phrase.keyMode, phrase.bars, phrase.meterNumerator,
|
||||
}, [phrase.material, pf.keyTonic, pf.keyMode, phrase.bars, phrase.meterNumerator,
|
||||
phrase.rhythmLevel, phrase.scaleDirection, phrase.scaleCoverage, phrase.scaleRhythm, phrase.libraryId,
|
||||
phrase.arpeggioDegree, phrase.arpeggioPattern, phrase.arpeggioCoverage,
|
||||
phrase.arpeggioBars, phrase.arpeggioProgression,
|
||||
@@ -323,9 +310,7 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
}, [scoreOk, fixedMaterial, pool, fullScore]);
|
||||
|
||||
const nextAction = useCallback(() => {
|
||||
if (phrase.material === 'melody' || (phrase.material === 'arpeggio' && phrase.arpeggioBars > 1)) {
|
||||
setMelodySeed(s => (s + 1) % 999983);
|
||||
} else if (fixedMaterial && scoreOk) {
|
||||
if (fixedMaterial && scoreOk) {
|
||||
const total = fullScore!.value.measures.length;
|
||||
const nextStart = phrase.startBar + phrase.barCount;
|
||||
if (nextStart > total) {
|
||||
@@ -333,6 +318,12 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
} else {
|
||||
setPhrase({ startBar: nextStart });
|
||||
}
|
||||
return;
|
||||
}
|
||||
// Seeded material: roll a new variation (giuliani and single-chord
|
||||
// arpeggios included — they take melodySeed too).
|
||||
if (phrase.material === 'melody' || phrase.material === 'arpeggio' || phrase.material === 'giuliani') {
|
||||
setMelodySeed(s => (s + 1) % 999983);
|
||||
}
|
||||
}, [phrase.material, phrase.startBar, phrase.barCount, fixedMaterial, scoreOk, fullScore, setPhrase]);
|
||||
|
||||
@@ -340,6 +331,7 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
useImperativeHandle(ref, () => ({
|
||||
pauseToggle: () => trainer?.pauseToggle(),
|
||||
previewToggle: () => trainer?.previewToggle(),
|
||||
previewStep: (dir) => trainer?.previewStep(dir),
|
||||
retry: () => trainer?.retry(),
|
||||
skip: () => trainer?.skip(),
|
||||
pause: () => trainer?.pause(),
|
||||
@@ -349,17 +341,22 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
// ---- Hints --------------------------------------------------------------
|
||||
const activeScore = trainer.activeScore;
|
||||
const events = scoreEvents(activeScore);
|
||||
const currentMidi = trainer.currentIdx >= 0 && events[trainer.currentIdx]?.pitch
|
||||
? events[trainer.currentIdx]!.pitch!.midi
|
||||
// While previewing, the hint instruments follow the preview cursor so
|
||||
// the user can find notes on the fretboard while listening.
|
||||
const displayIdx = trainer.phase === 'preview' || trainer.phase === 'previewPaused'
|
||||
? trainer.previewIdx
|
||||
: trainer.currentIdx;
|
||||
const currentMidi = displayIdx >= 0 && events[displayIdx]?.pitch
|
||||
? events[displayIdx]!.pitch!.midi
|
||||
: null;
|
||||
|
||||
const hintPositions = useMemo(() => {
|
||||
if (!settings.showHint || !currentInstrumentDef.showTuning || !currentTuning || currentMidi === null) return [];
|
||||
if (phrase.fretWindowEnabled) {
|
||||
return positionsWithinWindow(currentMidi, currentTuning, phrase.fretMin, phrase.fretMax);
|
||||
if (pf.fretWindowEnabled) {
|
||||
return positionsWithinWindow(currentMidi, currentTuning, pf.fretMin, pf.fretMax);
|
||||
}
|
||||
return getFretboardPositions(currentMidi, currentTuning);
|
||||
}, [settings.showHint, currentInstrumentDef, currentTuning, currentMidi, phrase.fretWindowEnabled, phrase.fretMin, phrase.fretMax]);
|
||||
}, [settings.showHint, currentInstrumentDef, currentTuning, currentMidi, pf.fretWindowEnabled, pf.fretMin, pf.fretMax]);
|
||||
|
||||
const handleVirtualPlay = useCallback((midi: number) => {
|
||||
if (!settings.virtualGuitarMute) {
|
||||
@@ -380,7 +377,8 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
const statusText = useMemo(() => {
|
||||
if (!scoreOk) return materialError ?? 'No material.';
|
||||
const p = trainer.phase;
|
||||
if (p === 'preview') return 'Listen …';
|
||||
if (p === 'preview') return 'Listen … (pause to step note by note)';
|
||||
if (p === 'previewPaused') return 'Paused — step with ⏮ ⏭ or ← →, resume with P';
|
||||
if (p === 'countIn') return `Count-in: ${trainer.countInLeft}`;
|
||||
if (p === 'paused') return 'Paused';
|
||||
if (p === 'done') {
|
||||
@@ -399,12 +397,13 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
const p = trainer.phase;
|
||||
if (p === 'playing' || p === 'countIn') return 'Pause';
|
||||
if (p === 'paused') return 'Resume';
|
||||
if (p === 'preview') return 'Stop preview';
|
||||
if (p === 'preview') return 'Pause';
|
||||
if (p === 'previewPaused') return 'Resume';
|
||||
return 'Start';
|
||||
}, [trainer.phase]);
|
||||
|
||||
const startAction = useMemo(() => {
|
||||
if (trainer.phase === 'preview') return trainer.previewToggle;
|
||||
if (trainer.phase === 'preview' || trainer.phase === 'previewPaused') return trainer.previewToggle;
|
||||
return trainer.pauseToggle;
|
||||
}, [trainer]);
|
||||
|
||||
@@ -452,118 +451,8 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
</span>
|
||||
</div>
|
||||
|
||||
<div className="sheet-music-container">
|
||||
{scoreOk ? (
|
||||
<PhraseSheetMusic
|
||||
score={trainer.activeScore}
|
||||
currentIdx={trainer.currentIdx}
|
||||
statuses={trainer.statuses}
|
||||
clef={activeClef}
|
||||
transpose={activeTranspose}
|
||||
width={staffWidth}
|
||||
theme={settings.theme}
|
||||
/>
|
||||
) : (
|
||||
<div className="phrase-error">{materialError}</div>
|
||||
)}
|
||||
</div>
|
||||
|
||||
{trainer.error && <div className="error-message">{trainer.error}</div>}
|
||||
{importError && <div className="error-message">{importError}</div>}
|
||||
{rangeWarning && <div className="phrase-warning">{rangeWarning}</div>}
|
||||
|
||||
<div className="feedback-area">
|
||||
{trainer.phase === 'countIn' && (
|
||||
<span
|
||||
className="phrase-countin"
|
||||
style={{
|
||||
display: 'inline-block',
|
||||
minWidth: '20px',
|
||||
padding: '1px 7px',
|
||||
marginRight: '8px',
|
||||
borderRadius: '10px',
|
||||
fontSize: '11px',
|
||||
opacity: 0.75,
|
||||
background: 'color-mix(in srgb, var(--color-text-main) 10%, transparent)',
|
||||
}}
|
||||
aria-label={`Count-in: ${trainer.countInLeft} beats left`}
|
||||
>{trainer.countInLeft}</span>
|
||||
)}
|
||||
<div className="instruction-text phrase-status">{statusText}</div>
|
||||
</div>
|
||||
|
||||
{/* Transport — reuses the single-note button styles/behavior */}
|
||||
<div className="action-row phrase-transport">
|
||||
<button className="skip-button" onClick={startAction} title="Start / Pause (Space)">
|
||||
{trainer.phase === 'playing' || trainer.phase === 'countIn' ? <Pause size={18} /> : <Play size={18} />}
|
||||
{startLabel}
|
||||
</button>
|
||||
{!settings.zenMode && (
|
||||
<>
|
||||
<button
|
||||
className="hint-button"
|
||||
onClick={trainer.previewToggle}
|
||||
title="Preview the phrase (P)"
|
||||
>
|
||||
{trainer.phase === 'preview' ? <Square size={18} /> : <Volume2 size={18} />}
|
||||
{trainer.phase === 'preview' ? 'Stop' : 'Preview'}
|
||||
</button>
|
||||
<button className="hint-button" onClick={trainer.retry} title="Retry from the start (R)">
|
||||
<RotateCcw size={18} />
|
||||
Retry
|
||||
</button>
|
||||
{(phrase.material === 'melody' || phrase.material === 'arpeggio' || fixedMaterial) && (
|
||||
<button className="hint-button" onClick={nextAction} title="New melody / next bars (N)">
|
||||
<SkipForward size={18} />
|
||||
{phrase.material === 'melody' ? 'New' : 'Next'}
|
||||
</button>
|
||||
)}
|
||||
{phrase.pace === 'step' && (
|
||||
<button className="hint-button" onClick={trainer.skip} title="Skip this note (S)">
|
||||
<SkipForward size={18} />
|
||||
Skip
|
||||
</button>
|
||||
)}
|
||||
</>
|
||||
)}
|
||||
{/* Same virtual-instrument / hint toggles as single-note mode */}
|
||||
{trainer.phase === 'done' && settings.zenMode && (
|
||||
<>
|
||||
<button className="hint-button" onClick={trainer.retry} title="Retry (R)">
|
||||
<RotateCcw size={18} />
|
||||
Retry
|
||||
</button>
|
||||
{(phrase.material === 'melody' || phrase.material === 'arpeggio' || fixedMaterial) && (
|
||||
<button className="hint-button" onClick={nextAction} title="New / Next (N)">
|
||||
<SkipForward size={18} />
|
||||
{phrase.material === 'melody' ? 'New' : 'Next'}
|
||||
</button>
|
||||
)}
|
||||
</>
|
||||
)}
|
||||
{!settings.zenMode && currentInstrumentDef.showTuning && (
|
||||
<button
|
||||
className={`hint-button ${settings.showFretboard ? 'active' : ''}`}
|
||||
onClick={() => setSettings(s => ({ ...s, showFretboard: !s.showFretboard }))}
|
||||
title={`Toggle Virtual ${currentInstrumentDef.displayName} (Keyboard Shortcut: V)`}
|
||||
>
|
||||
<Guitar size={18} />
|
||||
{currentInstrumentDef.id === 'piano' ? 'Piano' : 'Guitar'}
|
||||
</button>
|
||||
)}
|
||||
{!settings.zenMode && (
|
||||
<button
|
||||
className={`hint-button ${settings.showHint ? 'active' : ''}`}
|
||||
onClick={() => setSettings(s => ({ ...s, showHint: !s.showHint }))}
|
||||
title="Keyboard Shortcut: H"
|
||||
>
|
||||
<HelpCircle size={18} />
|
||||
{settings.showHint ? "Hide Hint" : "Show Hint"}
|
||||
</button>
|
||||
)}
|
||||
</div>
|
||||
|
||||
{/* Setup panel */}
|
||||
{/* Setup panel — above the notation, holds material options
|
||||
plus the shared note filter (key/strings/fret window) */}
|
||||
{!settings.zenMode && (
|
||||
<details className="phrase-setup">
|
||||
<summary><ChevronDown size={16} /> Setup</summary>
|
||||
@@ -579,12 +468,6 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
</select>
|
||||
</label>
|
||||
|
||||
{(phrase.material === 'melody' || phrase.material === 'scale' || phrase.material === 'arpeggio') && (
|
||||
<span style={{ fontSize: '11px', opacity: 0.7, alignSelf: 'center' }}>
|
||||
Key/mode: use the "Target key" controls below the sheet — shared across modes.
|
||||
</span>
|
||||
)}
|
||||
|
||||
{phrase.material === 'melody' && (
|
||||
<>
|
||||
<label>Bars
|
||||
@@ -799,12 +682,6 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
</label>
|
||||
)}
|
||||
|
||||
{fretted && (
|
||||
<span style={{ fontSize: '11px', opacity: 0.7, alignSelf: 'center' }}>
|
||||
Fret window: use the "Fret window" controls below the sheet — shared across modes.
|
||||
</span>
|
||||
)}
|
||||
|
||||
{/* Pace lives in the metronome widget now:
|
||||
'Sync to exercise' checked = tempo pace,
|
||||
unchecked = at-your-pace (step). */}
|
||||
@@ -816,11 +693,6 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
/>
|
||||
Virtual input only
|
||||
</label>
|
||||
{phrase.pace === 'tempo' && (
|
||||
<span style={{ fontSize: '11px', opacity: 0.7, alignSelf: 'center' }}>
|
||||
BPM + click: on the metronome widget below.
|
||||
</span>
|
||||
)}
|
||||
<label className="phrase-check">
|
||||
<input
|
||||
type="checkbox"
|
||||
@@ -839,15 +711,168 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
</label>
|
||||
</div>
|
||||
{phrase.pace === 'tempo' && (
|
||||
<p className="phrase-note">The run clicks a full count-in bar, then one click per beat. The metronome pendulum mirrors these beats — set the tempo on the metronome tool.</p>
|
||||
<p className="phrase-note">Tempo and click sound live on the metronome tool (Sync checked = the run sets the pace; unchecked = play at your own pace with a free metronome).</p>
|
||||
)}
|
||||
<p className="phrase-note">
|
||||
Matching checks pitch, not fingering — several fretboard positions produce the same pitch.
|
||||
For repeated identical notes, briefly release between notes so each attack is detected.
|
||||
</p>
|
||||
<TargetNoteControls />
|
||||
</details>
|
||||
)}
|
||||
|
||||
<div className="sheet-music-container">
|
||||
{scoreOk ? (
|
||||
<PhraseSheetMusic
|
||||
score={trainer.activeScore}
|
||||
currentIdx={trainer.phase === 'preview' || trainer.phase === 'previewPaused' ? trainer.previewIdx : trainer.currentIdx}
|
||||
statuses={trainer.statuses}
|
||||
clef={activeClef}
|
||||
transpose={activeTranspose}
|
||||
width={staffWidth}
|
||||
theme={settings.theme}
|
||||
/>
|
||||
) : (
|
||||
<div className="phrase-error">{materialError}</div>
|
||||
)}
|
||||
</div>
|
||||
|
||||
{trainer.error && <div className="error-message">{trainer.error}</div>}
|
||||
{importError && <div className="error-message">{importError}</div>}
|
||||
{rangeWarning && <div className="phrase-warning">{rangeWarning}</div>}
|
||||
|
||||
<div className="feedback-area">
|
||||
{trainer.phase === 'countIn' && (
|
||||
<span
|
||||
className="phrase-countin"
|
||||
style={{
|
||||
display: 'inline-block',
|
||||
minWidth: '20px',
|
||||
padding: '1px 7px',
|
||||
marginRight: '8px',
|
||||
borderRadius: '10px',
|
||||
fontSize: '11px',
|
||||
opacity: 0.75,
|
||||
background: 'color-mix(in srgb, var(--color-text-main) 10%, transparent)',
|
||||
}}
|
||||
aria-label={`Count-in: ${trainer.countInLeft} beats left`}
|
||||
>{trainer.countInLeft}</span>
|
||||
)}
|
||||
<div className="instruction-text phrase-status">{statusText}</div>
|
||||
</div>
|
||||
|
||||
{/* Transport — reuses the single-note button styles/behavior */}
|
||||
<div className="action-row phrase-transport">
|
||||
<button className="skip-button" onClick={startAction} title="Start / Pause (Space)">
|
||||
{trainer.phase === 'playing' || trainer.phase === 'countIn' ? <Pause size={18} /> : <Play size={18} />}
|
||||
{startLabel}
|
||||
</button>
|
||||
{!settings.zenMode && (
|
||||
<>
|
||||
{trainer.phase === 'previewPaused' && (
|
||||
<div className="transport-step-group" role="group" aria-label="Preview stepping">
|
||||
<button
|
||||
className="hint-button step-button"
|
||||
onClick={() => trainer.previewStep(-1)}
|
||||
title="One event back (while previewing)"
|
||||
aria-label="Step back"
|
||||
>
|
||||
<SkipBack size={16} />
|
||||
</button>
|
||||
<button
|
||||
className="hint-button step-button"
|
||||
onClick={() => trainer.previewStep(1)}
|
||||
title="One event forward (while previewing)"
|
||||
aria-label="Step forward"
|
||||
>
|
||||
<SkipForward size={16} />
|
||||
</button>
|
||||
</div>
|
||||
)}
|
||||
<button
|
||||
className={`hint-button ${trainer.phase === 'preview' || trainer.phase === 'previewPaused' ? 'active' : ''}`}
|
||||
onClick={trainer.previewToggle}
|
||||
title="Preview: play / pause / resume (P)"
|
||||
>
|
||||
{trainer.phase === 'preview'
|
||||
? <><Pause size={18} /> Pause</>
|
||||
: trainer.phase === 'previewPaused'
|
||||
? <><Play size={18} /> Resume</>
|
||||
: <><Volume2 size={18} /> Preview</>}
|
||||
</button>
|
||||
<button className="hint-button" onClick={trainer.retry} title="Retry from the start (R)">
|
||||
<RotateCcw size={18} />
|
||||
Retry
|
||||
</button>
|
||||
{(phrase.material === 'melody' || phrase.material === 'arpeggio' || phrase.material === 'giuliani' || fixedMaterial) && (
|
||||
<button className="hint-button" onClick={nextAction} title="New melody / next bars (N)">
|
||||
<SkipForward size={18} />
|
||||
{(fixedMaterial || phrase.material === 'scale') ? 'Next' : 'New'}
|
||||
</button>
|
||||
)}
|
||||
{phrase.pace === 'step' && (
|
||||
<button className="hint-button" onClick={trainer.skip} title="Skip this note (S)">
|
||||
<SkipForward size={18} />
|
||||
Skip
|
||||
</button>
|
||||
)}
|
||||
</>
|
||||
)}
|
||||
{/* Same virtual-instrument / hint toggles as single-note mode */}
|
||||
{trainer.phase === 'done' && settings.zenMode && (
|
||||
<>
|
||||
<button className="hint-button" onClick={trainer.retry} title="Retry (R)">
|
||||
<RotateCcw size={18} />
|
||||
Retry
|
||||
</button>
|
||||
{(phrase.material === 'melody' || phrase.material === 'arpeggio' || phrase.material === 'giuliani' || fixedMaterial) && (
|
||||
<button className="hint-button" onClick={nextAction} title="New / Next (N)">
|
||||
<SkipForward size={18} />
|
||||
{(fixedMaterial || phrase.material === 'scale') ? 'Next' : 'New'}
|
||||
</button>
|
||||
)}
|
||||
</>
|
||||
)}
|
||||
</div>
|
||||
|
||||
{/* Display toggles — separate row, switch style (like the
|
||||
tuner/metronome switches): pure show/hide, no run state. */}
|
||||
{!settings.zenMode && (
|
||||
<div className="display-toggles">
|
||||
{currentInstrumentDef.showTuning && (
|
||||
<div className="display-toggle">
|
||||
<span className="display-toggle-label">
|
||||
<Guitar size={15} />
|
||||
{currentInstrumentDef.id === 'piano' ? 'Piano' : 'Guitar'}
|
||||
</span>
|
||||
<button
|
||||
className={`switch-button ${settings.showFretboard ? 'active' : ''}`}
|
||||
onClick={() => setSettings(s => ({ ...s, showFretboard: !s.showFretboard }))}
|
||||
title={`Toggle Virtual ${currentInstrumentDef.displayName} (Keyboard Shortcut: V)`}
|
||||
aria-label={`Show virtual ${currentInstrumentDef.displayName}`}
|
||||
>
|
||||
<div className="switch-thumb" />
|
||||
</button>
|
||||
</div>
|
||||
)}
|
||||
<div className="display-toggle">
|
||||
<span className="display-toggle-label">
|
||||
<HelpCircle size={15} />
|
||||
Hint
|
||||
</span>
|
||||
<button
|
||||
className={`switch-button ${settings.showHint ? 'active' : ''}`}
|
||||
onClick={() => setSettings(s => ({ ...s, showHint: !s.showHint }))}
|
||||
title="Keyboard Shortcut: H"
|
||||
aria-label="Show hint"
|
||||
>
|
||||
<div className="switch-thumb" />
|
||||
</button>
|
||||
</div>
|
||||
</div>
|
||||
)}
|
||||
|
||||
|
||||
{/* Hint instruments */}
|
||||
{(settings.showHint || settings.showFretboard) && currentInstrumentDef.showTuning && (
|
||||
<div className="hint-card">
|
||||
@@ -878,7 +903,7 @@ export const PhraseTrainer = forwardRef<PhraseHandle, PhraseTrainerProps>(
|
||||
onPlayNote={handleVirtualPlay}
|
||||
onHover={setHoveredMidi}
|
||||
showHints={settings.showHint}
|
||||
maxFrets={Math.max(15, phrase.fretWindowEnabled ? phrase.fretMax + 1 : 0)}
|
||||
maxFrets={Math.max(15, pf.fretWindowEnabled ? pf.fretMax + 1 : 0)}
|
||||
/>
|
||||
)
|
||||
)}
|
||||
|
||||
@@ -1,8 +1,32 @@
|
||||
import React, { useState } from 'react';
|
||||
import { X, Volume2, VolumeX, ChevronDown, ChevronUp, Mic, MicOff, Sun, Moon, Monitor, Clock } from 'lucide-react';
|
||||
import { X, Volume2, VolumeX, ChevronDown, ChevronUp, Mic, MicOff, Sun, Moon, Monitor, Clock, Guitar } from 'lucide-react';
|
||||
import type { AppSettings } from '../types/SettingsTypes';
|
||||
import { MIC_SENSITIVITY_DB_RANGE, MIC_DEFAULT_SENSITIVITY } from '../AppConfig';
|
||||
import type { MicrophoneDebugInfo } from '../hooks/usePitchDetector';
|
||||
import { TUNINGS, INSTRUMENT_TUNINGS } from '../music/Tunings';
|
||||
import { INSTRUMENT_DEFINITIONS } from '../music/InstrumentConfigs';
|
||||
|
||||
/** Collapsible settings section. First section open by default. */
|
||||
const Section: React.FC<{ title: string; defaultOpen?: boolean; children: React.ReactNode }> = ({ title, defaultOpen = false, children }) => {
|
||||
const [open, setOpen] = useState(defaultOpen);
|
||||
return (
|
||||
<div style={{ borderBottom: '1px solid color-mix(in srgb, var(--color-text-main) 10%, transparent)' }}>
|
||||
<button
|
||||
onClick={() => setOpen(o => !o)}
|
||||
style={{
|
||||
width: '100%', background: 'transparent', border: 'none', color: 'inherit',
|
||||
display: 'flex', alignItems: 'center', justifyContent: 'space-between',
|
||||
padding: '14px 0', cursor: 'pointer', font: 'inherit'
|
||||
}}
|
||||
aria-expanded={open}
|
||||
>
|
||||
<span style={{ fontSize: '15px', fontWeight: 600 }}>{title}</span>
|
||||
{open ? <ChevronUp size={16} style={{ opacity: 0.6 }} /> : <ChevronDown size={16} style={{ opacity: 0.6 }} />}
|
||||
</button>
|
||||
{open && <div style={{ paddingBottom: '20px' }}>{children}</div>}
|
||||
</div>
|
||||
);
|
||||
};
|
||||
|
||||
interface SettingsModalProps {
|
||||
isOpen: boolean;
|
||||
@@ -78,7 +102,52 @@ export const SettingsModal: React.FC<SettingsModalProps> = ({
|
||||
<div className="help-popup-overlay" onClick={onClose}>
|
||||
<div className="help-popup" onClick={e => e.stopPropagation()}>
|
||||
<button className="help-close" onClick={onClose}><X size={20} /></button>
|
||||
<h2 style={{ marginTop: 0, marginBottom: '24px' }}>Settings</h2>
|
||||
<h2 style={{ marginTop: 0, marginBottom: '12px' }}>Settings</h2>
|
||||
|
||||
{/* Instrument & Tuning (rarely changed — lives here now) */}
|
||||
<Section title="Instrument" defaultOpen>
|
||||
<div className="control-group" style={{ marginBottom: '16px' }}>
|
||||
<label className="control-label" style={{ marginBottom: '8px', fontSize: '16px' }}>
|
||||
<Guitar size={18} />
|
||||
<span>Instrument</span>
|
||||
</label>
|
||||
<select
|
||||
value={settings.instrument}
|
||||
onChange={(e) => {
|
||||
const id = e.target.value;
|
||||
const def = INSTRUMENT_DEFINITIONS[id];
|
||||
let tuningId = settings.tuningId;
|
||||
if (def.showTuning && INSTRUMENT_TUNINGS[id as 'guitar' | 'bass']) {
|
||||
tuningId = INSTRUMENT_TUNINGS[id as 'guitar' | 'bass'][0];
|
||||
}
|
||||
onUpdateSettings({ ...settings, instrument: id, difficulty: def.ranges[0].id, tuningId });
|
||||
}}
|
||||
className="control-select"
|
||||
>
|
||||
{Object.values(INSTRUMENT_DEFINITIONS).map(def => (
|
||||
<option key={def.id} value={def.id}>{def.displayName}</option>
|
||||
))}
|
||||
</select>
|
||||
</div>
|
||||
{INSTRUMENT_DEFINITIONS[settings.instrument]?.showTuning && INSTRUMENT_TUNINGS[settings.instrument as 'guitar' | 'bass'] && (
|
||||
<div className="control-group">
|
||||
<label className="control-label" style={{ marginBottom: '8px', fontSize: '16px' }}>
|
||||
<span>Tuning</span>
|
||||
</label>
|
||||
<select
|
||||
value={settings.tuningId}
|
||||
onChange={(e) => onUpdateSettings({ ...settings, tuningId: e.target.value })}
|
||||
className="control-select"
|
||||
>
|
||||
{INSTRUMENT_TUNINGS[settings.instrument as 'guitar' | 'bass'].map(id => (
|
||||
<option key={id} value={id}>{TUNINGS[id]?.name ?? id}</option>
|
||||
))}
|
||||
</select>
|
||||
</div>
|
||||
)}
|
||||
</Section>
|
||||
|
||||
<Section title="Appearance">
|
||||
|
||||
{/* Theme Settings */}
|
||||
<div className="control-group" style={{ marginBottom: '24px' }}>
|
||||
@@ -119,8 +188,6 @@ export const SettingsModal: React.FC<SettingsModalProps> = ({
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<hr style={{ borderColor: 'rgba(255,255,255,0.1)', margin: '24px 0' }} />
|
||||
|
||||
{/* Animation Settings */}
|
||||
<div className="control-group" style={{ marginBottom: '24px' }}>
|
||||
<div style={{ display: 'flex', alignItems: 'center', justifyContent: 'space-between', marginBottom: '8px' }}>
|
||||
@@ -140,7 +207,9 @@ export const SettingsModal: React.FC<SettingsModalProps> = ({
|
||||
</p>
|
||||
</div>
|
||||
|
||||
<hr style={{ borderColor: 'rgba(255,255,255,0.1)', margin: '24px 0' }} />
|
||||
</Section>
|
||||
|
||||
<Section title="Audio" defaultOpen>
|
||||
|
||||
<div className="control-group" style={{ marginBottom: '24px' }}>
|
||||
<div style={{ display: 'flex', alignItems: 'center', justifyContent: 'space-between', marginBottom: '8px' }}>
|
||||
@@ -261,7 +330,9 @@ export const SettingsModal: React.FC<SettingsModalProps> = ({
|
||||
</p>
|
||||
</div>
|
||||
|
||||
<hr style={{ borderColor: 'rgba(255,255,255,0.1)', margin: '24px 0' }} />
|
||||
</Section>
|
||||
|
||||
<Section title="Microphone" defaultOpen>
|
||||
|
||||
{/* Microphone Toggle */}
|
||||
<div className="control-group" style={{ marginBottom: '16px' }}>
|
||||
@@ -434,6 +505,8 @@ export const SettingsModal: React.FC<SettingsModalProps> = ({
|
||||
)}
|
||||
</div>
|
||||
)}
|
||||
|
||||
</Section>
|
||||
</div>
|
||||
|
||||
</div>
|
||||
|
||||
@@ -149,38 +149,57 @@ export const SingleNoteTrainer = forwardRef<SingleNoteHandle, SingleNoteTrainerP
|
||||
)}
|
||||
|
||||
{!settings.zenMode && (
|
||||
<div className="action-row" style={{ marginTop: '24px', display: 'flex', justifyContent: 'center', gap: '16px' }}>
|
||||
{currentInstrumentDef.showTuning && (
|
||||
<>
|
||||
{/* Display toggles — switch style (like phrase mode):
|
||||
pure show/hide, no trainer actions. */}
|
||||
<div className="display-toggles" style={{ marginTop: '24px' }}>
|
||||
{currentInstrumentDef.showTuning && (
|
||||
<div className="display-toggle">
|
||||
<span className="display-toggle-label">
|
||||
<Guitar size={15} />
|
||||
{currentInstrumentDef.id === 'piano' ? 'Piano' : 'Guitar'}
|
||||
</span>
|
||||
<button
|
||||
className={`switch-button ${settings.showFretboard ? 'active' : ''}`}
|
||||
onClick={() => setSettings(s => ({ ...s, showFretboard: !s.showFretboard }))}
|
||||
title={`Toggle Virtual ${currentInstrumentDef.displayName} (Keyboard Shortcut: V)`}
|
||||
aria-label={`Show virtual ${currentInstrumentDef.displayName}`}
|
||||
>
|
||||
<div className="switch-thumb" />
|
||||
</button>
|
||||
</div>
|
||||
)}
|
||||
<div className="display-toggle">
|
||||
<span className="display-toggle-label">
|
||||
<HelpCircle size={15} />
|
||||
Hint
|
||||
</span>
|
||||
<button
|
||||
className={`switch-button ${settings.showHint ? 'active' : ''}`}
|
||||
onClick={() => setSettings(s => ({ ...s, showHint: !s.showHint }))}
|
||||
title="Keyboard Shortcut: H"
|
||||
aria-label="Show hint"
|
||||
>
|
||||
<div className="switch-thumb" />
|
||||
</button>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<div className="action-row" style={{ marginTop: '16px', display: 'flex', justifyContent: 'center', gap: '16px' }}>
|
||||
<button
|
||||
className={`hint-button ${settings.showFretboard ? 'active' : ''}`}
|
||||
onClick={() => setSettings(s => ({ ...s, showFretboard: !s.showFretboard }))}
|
||||
title={`Toggle Virtual ${currentInstrumentDef.displayName} (Keyboard Shortcut: V)`}
|
||||
className="hint-button"
|
||||
onClick={() => playNote(targetMidi, settings.referenceNoteDuration ?? 1.5, settings.autoPlayVolume ?? 0.5)}
|
||||
title="Keyboard Shortcut: P or R"
|
||||
>
|
||||
<Guitar size={18} />
|
||||
{currentInstrumentDef.id === 'piano' ? 'Piano' : 'Guitar'}
|
||||
<Volume2 size={18} />
|
||||
Play Note
|
||||
</button>
|
||||
)}
|
||||
<button
|
||||
className={`hint-button ${settings.showHint ? 'active' : ''}`}
|
||||
onClick={() => setSettings(s => ({ ...s, showHint: !s.showHint }))}
|
||||
title="Keyboard Shortcut: H"
|
||||
>
|
||||
<HelpCircle size={18} />
|
||||
{settings.showHint ? "Hide Hint" : "Show Hint"}
|
||||
</button>
|
||||
<button
|
||||
className="hint-button"
|
||||
onClick={() => playNote(targetMidi, settings.referenceNoteDuration ?? 1.5, settings.autoPlayVolume ?? 0.5)}
|
||||
title="Keyboard Shortcut: P or R"
|
||||
>
|
||||
<Volume2 size={18} />
|
||||
Play Note
|
||||
</button>
|
||||
<button className="skip-button" onClick={() => generateNewNote()} title="Keyboard Shortcut: Space">
|
||||
<SkipForward size={18} />
|
||||
Skip Note
|
||||
</button>
|
||||
</div>
|
||||
<button className="skip-button" onClick={() => generateNewNote()} title="Keyboard Shortcut: Space">
|
||||
<SkipForward size={18} />
|
||||
Skip Note
|
||||
</button>
|
||||
</div>
|
||||
</>
|
||||
)}
|
||||
</div>
|
||||
);
|
||||
|
||||
@@ -6,8 +6,10 @@
|
||||
* - Strings: pick which strings contribute target notes (fretted instruments).
|
||||
* - Fret window: restrict target notes to a fret range (fretted instruments).
|
||||
*
|
||||
* In Phrase Mode the same controls bind to the shared practice filter
|
||||
* (mirrored into phrase settings), so state stays consistent across modes.
|
||||
* In Phrase Mode the Key section binds to the generator key (tonic+mode are
|
||||
* always applied; no toggle), and the display-signature sync checkbox is
|
||||
* hidden (phrase notation takes its signature from the score's key).
|
||||
* Rendered inside the per-mode Setup panel above the notation.
|
||||
*/
|
||||
import { useMemo } from 'react';
|
||||
import { Key, Guitar, Music, SlidersHorizontal } from 'lucide-react';
|
||||
@@ -46,6 +48,8 @@ const MINOR_TONIC_TO_SIGNATURE: Record<string, string> = {
|
||||
export const TargetNoteControls: React.FC = () => {
|
||||
const { settings, updateSettings } = useSettings();
|
||||
const pf = getPracticeFilter(settings);
|
||||
// Phrase Mode: key tonic/mode are the generator key — always in effect.
|
||||
const inPhraseMode = settings.gameMode === 'phrase';
|
||||
|
||||
const setFilter = (updates: Partial<PracticeFilter>) => {
|
||||
updateSettings(s => {
|
||||
@@ -81,7 +85,8 @@ export const TargetNoteControls: React.FC = () => {
|
||||
|
||||
const allSelected = pf.strings.length === 0;
|
||||
|
||||
const anyActive = pf.keyEnabled || pf.fretWindowEnabled || pf.strings.length > 0;
|
||||
const anyActive =
|
||||
(!inPhraseMode && pf.keyEnabled) || pf.fretWindowEnabled || pf.strings.length > 0;
|
||||
return (
|
||||
<div className="practice-filter-grid" style={{ display: 'flex', flexDirection: 'column', gap: '8px', border: '1px solid rgba(128,128,128,0.2)', padding: '12px', borderRadius: '8px', gridColumn: '1 / -1' }}>
|
||||
{/* Section header: unified with Tuner/Metronome style */}
|
||||
@@ -108,15 +113,17 @@ export const TargetNoteControls: React.FC = () => {
|
||||
<Key size={18} />
|
||||
<span>Key</span>
|
||||
</label>
|
||||
<button
|
||||
className={`switch-button ${pf.keyEnabled ? 'active' : ''}`}
|
||||
onClick={() => setFilter({ keyEnabled: !pf.keyEnabled })}
|
||||
title={pf.keyEnabled ? 'Limit to key: on' : 'Limit to key: off'}
|
||||
>
|
||||
<div className="switch-thumb" />
|
||||
</button>
|
||||
{!inPhraseMode && (
|
||||
<button
|
||||
className={`switch-button ${pf.keyEnabled ? 'active' : ''}`}
|
||||
onClick={() => setFilter({ keyEnabled: !pf.keyEnabled })}
|
||||
title={pf.keyEnabled ? 'Limit to key: on' : 'Limit to key: off'}
|
||||
>
|
||||
<div className="switch-thumb" />
|
||||
</button>
|
||||
)}
|
||||
</div>
|
||||
{pf.keyEnabled && (
|
||||
{(pf.keyEnabled || inPhraseMode) && (
|
||||
<>
|
||||
<div style={{ display: 'flex', gap: '8px', marginTop: '8px' }}>
|
||||
<select
|
||||
@@ -140,23 +147,25 @@ export const TargetNoteControls: React.FC = () => {
|
||||
))}
|
||||
</select>
|
||||
</div>
|
||||
<label style={{ fontSize: '11px', display: 'flex', alignItems: 'center', gap: '6px', marginTop: '6px', opacity: 0.85 }}>
|
||||
<input
|
||||
type="checkbox"
|
||||
checked={settings.keyFollowsTarget ?? false}
|
||||
onChange={e => updateSettings(s => {
|
||||
const next = { ...s, keyFollowsTarget: e.target.checked };
|
||||
// When enabling sync, snap the display signature now.
|
||||
if (e.target.checked) {
|
||||
const table = pf.keyMode === 'minor' ? MINOR_TONIC_TO_SIGNATURE : MAJOR_TONIC_TO_SIGNATURE;
|
||||
const sig = table[pf.keyTonic];
|
||||
if (sig) next.keySignature = sig;
|
||||
}
|
||||
return next;
|
||||
})}
|
||||
/>
|
||||
Sync display key signature with target key
|
||||
</label>
|
||||
{!inPhraseMode && (
|
||||
<label style={{ fontSize: '11px', display: 'flex', alignItems: 'center', gap: '6px', marginTop: '6px', opacity: 0.85 }}>
|
||||
<input
|
||||
type="checkbox"
|
||||
checked={settings.keyFollowsTarget ?? false}
|
||||
onChange={e => updateSettings(s => {
|
||||
const next = { ...s, keyFollowsTarget: e.target.checked };
|
||||
// When enabling sync, snap the display signature now.
|
||||
if (e.target.checked) {
|
||||
const table = pf.keyMode === 'minor' ? MINOR_TONIC_TO_SIGNATURE : MAJOR_TONIC_TO_SIGNATURE;
|
||||
const sig = table[pf.keyTonic];
|
||||
if (sig) next.keySignature = sig;
|
||||
}
|
||||
return next;
|
||||
})}
|
||||
/>
|
||||
Sync display key signature with target key
|
||||
</label>
|
||||
)}
|
||||
</>
|
||||
)}
|
||||
</div>
|
||||
|
||||
@@ -85,7 +85,11 @@ export const useGameLogic = (
|
||||
|
||||
const { restart: restartMetronome } = useMetronome({
|
||||
bpm: effectiveBpm,
|
||||
volume: settings.rhythm.sound ? settings.rhythm.volume : 0,
|
||||
// Audible clicks come from the shared footer widget (Controls) in
|
||||
// non-zen single-note modes — this scheduler is only the tick source
|
||||
// for auto-advance. Sounding it here too doubles every beat. In zen
|
||||
// mode the widget isn't rendered, so this scheduler IS the click.
|
||||
volume: settings.zenMode && settings.rhythm.sound ? settings.rhythm.volume : 0,
|
||||
playing: settings.rhythm.active,
|
||||
onTick: handleTick
|
||||
});
|
||||
|
||||
@@ -34,6 +34,8 @@ export function useMetronome({ bpm, volume, playing, onTick }: MetronomeOptions)
|
||||
|
||||
const playClick = useCallback((time: number) => {
|
||||
if (!audioContext.current) return;
|
||||
onTickRef.current(currentBeat.current);
|
||||
if (volume <= 0) return; // silent tick source — no audio nodes needed
|
||||
|
||||
const osc = audioContext.current.createOscillator();
|
||||
const gainNode = audioContext.current.createGain();
|
||||
|
||||
@@ -21,7 +21,7 @@ import { subscribeRawFrames } from './rawFrameBus';
|
||||
import { phraseRunBus } from './phraseRunBus';
|
||||
import { phraseBeatBus } from './phraseBeatBus';
|
||||
|
||||
export type PhrasePhase = 'ready' | 'countIn' | 'playing' | 'paused' | 'preview' | 'done';
|
||||
export type PhrasePhase = 'ready' | 'countIn' | 'playing' | 'paused' | 'preview' | 'previewPaused' | 'done';
|
||||
|
||||
export interface PhraseSelection {
|
||||
readonly startBar: number;
|
||||
@@ -56,6 +56,8 @@ const REARM_AFTER_SUSTAINED_MS = 2500;
|
||||
|
||||
export interface PhraseTrainerApi {
|
||||
readonly phase: PhrasePhase;
|
||||
/** Event index the preview cursor points at (-1 when not previewing). */
|
||||
readonly previewIdx: number;
|
||||
/** Active slice the user is currently working through (may be a resume tail). */
|
||||
readonly activeScore: Score;
|
||||
readonly statuses: NoteStatus[];
|
||||
@@ -76,6 +78,9 @@ export interface PhraseTrainerApi {
|
||||
retry: () => void;
|
||||
skip: () => void;
|
||||
previewToggle: () => void;
|
||||
/** While previewing: step one event forward/backward (player-style).
|
||||
* Plays the note at the new position and moves the preview indicator. */
|
||||
previewStep: (dir: 1 | -1) => void;
|
||||
virtualTap: (midi: number) => void;
|
||||
/** External pause (settings dialog, visibility change handled internally). */
|
||||
pause: () => void;
|
||||
@@ -95,6 +100,7 @@ export function usePhraseTrainer(
|
||||
const [countInLeft, setCountInLeft] = useState(0);
|
||||
const [error, setError] = useState<string | null>(null);
|
||||
const [repeatedNoteBlocked, setRepeatedNoteBlocked] = useState(false);
|
||||
const [previewIdx, setPreviewIdx] = useState(-1);
|
||||
const [accumulated, setAccumulated] = useState<PhraseSummary>({ total: 0, matched: 0, missed: 0, skipped: 0 });
|
||||
|
||||
// ---- Active slice (resume tails replace it) ---------------------------
|
||||
@@ -102,6 +108,8 @@ export function usePhraseTrainer(
|
||||
|
||||
const matcherRef = useRef<PhraseMatcher | null>(null);
|
||||
const repeatBlockedRef = useRef(false);
|
||||
const previewIdxRef = useRef(-1);
|
||||
const previewToggleRef = useRef<(() => void) | null>(null);
|
||||
const phaseRef = useRef<PhrasePhase>('ready');
|
||||
const paceRef = useRef(config.pace);
|
||||
const configRef = useRef(config);
|
||||
@@ -117,6 +125,10 @@ export function usePhraseTrainer(
|
||||
const runTokenRef = useRef(0);
|
||||
const repeatTimerRef = useRef<ReturnType<typeof setTimeout> | null>(null);
|
||||
const previewTimerRef = useRef<ReturnType<typeof setTimeout> | null>(null);
|
||||
/** Audio time the preview cursor is scheduled to reach (for pause). */
|
||||
const previewEndAtRef = useRef(0);
|
||||
/** Audio-time interval that advances the preview cursor. */
|
||||
const previewTickRef = useRef<ReturnType<typeof setInterval> | null>(null);
|
||||
|
||||
const events = useMemo(() => scoreEvents(activeScore), [activeScore]);
|
||||
|
||||
@@ -157,6 +169,9 @@ export function usePhraseTrainer(
|
||||
setAccumulated({ total: 0, matched: 0, missed: 0, skipped: 0 });
|
||||
audioEngine.cancelGroup(PREVIEW_GROUP);
|
||||
audioEngine.cancelGroup(CLICK_GROUP);
|
||||
if (previewTickRef.current) { clearInterval(previewTickRef.current); previewTickRef.current = null; }
|
||||
previewIdxRef.current = -1;
|
||||
setPreviewIdx(-1);
|
||||
setPhaseBoth('ready');
|
||||
setCurrentIdx(-1);
|
||||
setCountInLeft(0);
|
||||
@@ -388,6 +403,15 @@ export function usePhraseTrainer(
|
||||
const pauseInternalRef = useRef<(() => void) | null>(null);
|
||||
|
||||
const pause = useCallback(() => {
|
||||
if (phaseRef.current === 'preview') {
|
||||
// External pause during preview behaves like preview pause
|
||||
// (cursor kept, stepping enabled) but without phase recursion.
|
||||
audioEngine.cancelGroup(PREVIEW_GROUP);
|
||||
if (previewTickRef.current) { clearInterval(previewTickRef.current); previewTickRef.current = null; }
|
||||
if (previewTimerRef.current) { clearTimeout(previewTimerRef.current); previewTimerRef.current = null; }
|
||||
setPhaseBoth('previewPaused');
|
||||
return;
|
||||
}
|
||||
if (phaseRef.current !== 'playing' && phaseRef.current !== 'countIn') return;
|
||||
if (repeatTimerRef.current) { clearTimeout(repeatTimerRef.current); repeatTimerRef.current = null; }
|
||||
audioEngine.cancelGroup(CLICK_GROUP);
|
||||
@@ -462,7 +486,7 @@ export function usePhraseTrainer(
|
||||
if (paceRef.current === 'tempo') resumeTempo();
|
||||
else setPhaseBoth('playing');
|
||||
} else if (p === 'ready' || p === 'done') start();
|
||||
// preview: handled by previewToggle
|
||||
else if (p === 'preview' || p === 'previewPaused') previewToggleRef.current?.();
|
||||
}, [pause, resumeTempo, setPhaseBoth, start]);
|
||||
|
||||
const retry = useCallback(() => {
|
||||
@@ -485,46 +509,115 @@ export function usePhraseTrainer(
|
||||
advanceStep(m);
|
||||
}, [advanceStep]);
|
||||
|
||||
const previewToggle = useCallback(() => {
|
||||
if (phaseRef.current === 'preview') {
|
||||
audioEngine.cancelGroup(PREVIEW_GROUP);
|
||||
if (previewTimerRef.current) { clearTimeout(previewTimerRef.current); previewTimerRef.current = null; }
|
||||
setPhaseBoth('ready');
|
||||
return;
|
||||
}
|
||||
pause();
|
||||
runTokenRef.current++;
|
||||
const token = runTokenRef.current;
|
||||
/** Preview from event `fromIdx` to the end. A cursor interval mirrors
|
||||
* playback time so the notation indicator follows the sounding note. */
|
||||
const playPreviewFrom = useCallback((fromIdx: number, token: number) => {
|
||||
void audioEngine.ensureRunning().then(() => {
|
||||
if (runTokenRef.current !== token) return;
|
||||
const bpm = sanitizeBpm(configRef.current.bpm);
|
||||
const spb = 60 / bpm;
|
||||
const t0 = audioEngine.now() + 0.15;
|
||||
const vol = configRef.current.previewVolume ?? 0.4;
|
||||
const startTick = fromIdx > 0 ? events[fromIdx].startTick : 0;
|
||||
const totalTicks = events.reduce((a, e) => Math.max(a, e.startTick + e.durationTicks), 0);
|
||||
const secPerTick = spb / PPQ;
|
||||
for (const e of events) {
|
||||
if (!e.pitch) continue;
|
||||
audioEngine.scheduleNote(e.pitch.midi, t0 + (e.startTick / PPQ) * spb, (e.durationTicks / PPQ) * spb, vol, PREVIEW_GROUP);
|
||||
if (e.startTick < startTick) continue;
|
||||
audioEngine.scheduleNote(e.pitch.midi, t0 + ((e.startTick - startTick) / PPQ) * spb, (e.durationTicks / PPQ) * spb, vol, PREVIEW_GROUP);
|
||||
}
|
||||
// Tempo pace: click along with the preview so the rhythm is
|
||||
// audible while listening (quarter beats over the full span).
|
||||
// Registered in PREVIEW_GROUP so stopping the preview also stops
|
||||
// its clicks (no ghost metronomes after an aborted preview).
|
||||
if (paceRef.current === 'tempo' && configRef.current.clickSound) {
|
||||
const totalTicks = events.reduce((a, e) => Math.max(a, e.startTick + e.durationTicks), 0);
|
||||
const beats = Math.floor(totalTicks / PPQ);
|
||||
const beats = Math.floor((totalTicks - startTick) / PPQ);
|
||||
for (let i = 0; i < beats; i++) {
|
||||
audioEngine.playClickAt(t0 + i * spb, CLICK_VOLUME, i % 4 === 0, PREVIEW_GROUP);
|
||||
audioEngine.playClickAt(t0 + i * spb, CLICK_VOLUME, (fromIdx + i) % 4 === 0, PREVIEW_GROUP);
|
||||
}
|
||||
}
|
||||
setPhaseBoth('preview');
|
||||
const totalSec = (events.reduce((a, e) => Math.max(a, e.startTick + e.durationTicks), 0) / PPQ) * spb;
|
||||
previewTimerRef.current = setTimeout(() => {
|
||||
if (runTokenRef.current === token) {
|
||||
|
||||
// Cursor: advance previewIdx by audio time (event start ticks).
|
||||
previewEndAtRef.current = t0 + (totalTicks - startTick) * secPerTick;
|
||||
if (previewTickRef.current) clearInterval(previewTickRef.current);
|
||||
previewTickRef.current = setInterval(() => {
|
||||
if (phaseRef.current !== 'preview' || runTokenRef.current !== token) {
|
||||
if (previewTickRef.current) { clearInterval(previewTickRef.current); previewTickRef.current = null; }
|
||||
return;
|
||||
}
|
||||
const elapsedTicks = Math.max(0, (audioEngine.now() - t0) / secPerTick) + startTick;
|
||||
let idx = previewIdxRef.current;
|
||||
let advanced = false;
|
||||
while (idx + 1 < events.length && events[idx + 1].startTick <= elapsedTicks) { idx++; advanced = true; }
|
||||
if (advanced) { previewIdxRef.current = idx; setPreviewIdx(idx); }
|
||||
if (audioEngine.now() >= previewEndAtRef.current + 0.2) {
|
||||
if (previewTickRef.current) { clearInterval(previewTickRef.current); previewTickRef.current = null; }
|
||||
previewIdxRef.current = -1;
|
||||
setPreviewIdx(-1);
|
||||
setPhaseBoth('ready');
|
||||
}
|
||||
}, 150 + totalSec * 1000 + 200);
|
||||
}, 60);
|
||||
});
|
||||
}, [events, pause, setPhaseBoth]);
|
||||
}, [events, setPhaseBoth]);
|
||||
|
||||
const stopPreview = useCallback(() => {
|
||||
audioEngine.cancelGroup(PREVIEW_GROUP);
|
||||
if (previewTimerRef.current) { clearTimeout(previewTimerRef.current); previewTimerRef.current = null; }
|
||||
if (previewTickRef.current) { clearInterval(previewTickRef.current); previewTickRef.current = null; }
|
||||
previewIdxRef.current = -1;
|
||||
setPreviewIdx(-1);
|
||||
setPhaseBoth('ready');
|
||||
}, [setPhaseBoth]);
|
||||
|
||||
/** Pause preview: stop scheduled audio, keep the cursor position. */
|
||||
const previewPause = useCallback(() => {
|
||||
if (phaseRef.current !== 'preview') return;
|
||||
audioEngine.cancelGroup(PREVIEW_GROUP);
|
||||
if (previewTimerRef.current) { clearTimeout(previewTimerRef.current); previewTimerRef.current = null; }
|
||||
if (previewTickRef.current) { clearInterval(previewTickRef.current); previewTickRef.current = null; }
|
||||
setPhaseBoth('previewPaused');
|
||||
}, [setPhaseBoth]);
|
||||
|
||||
const previewToggle = useCallback(() => {
|
||||
const p = phaseRef.current;
|
||||
if (p === 'preview') {
|
||||
previewPause();
|
||||
return;
|
||||
}
|
||||
if (p === 'previewPaused') {
|
||||
// Resume from the paused cursor position.
|
||||
runTokenRef.current++;
|
||||
const token = runTokenRef.current;
|
||||
playPreviewFrom(previewIdxRef.current, token);
|
||||
return;
|
||||
}
|
||||
pause();
|
||||
runTokenRef.current++;
|
||||
const token = runTokenRef.current;
|
||||
previewIdxRef.current = 0;
|
||||
setPreviewIdx(0);
|
||||
playPreviewFrom(0, token);
|
||||
}, [pause, playPreviewFrom, previewPause, stopPreview]);
|
||||
previewToggleRef.current = previewToggle;
|
||||
|
||||
/** Player-style stepping — only while the preview is PAUSED: move the
|
||||
* cursor one event and play that single note (find-it-on-the-neck). */
|
||||
const previewStep = useCallback((dir: 1 | -1) => {
|
||||
if (phaseRef.current !== 'previewPaused') return;
|
||||
const nextIdx = Math.max(0, Math.min(events.length - 1, previewIdxRef.current + dir));
|
||||
if (nextIdx === previewIdxRef.current) return;
|
||||
previewIdxRef.current = nextIdx;
|
||||
setPreviewIdx(nextIdx);
|
||||
// Play just this one event as an audible cue.
|
||||
runTokenRef.current++;
|
||||
const token = runTokenRef.current;
|
||||
const e = events[nextIdx];
|
||||
void audioEngine.ensureRunning().then(() => {
|
||||
if (runTokenRef.current !== token || !e.pitch) return;
|
||||
audioEngine.scheduleNote(e.pitch.midi, audioEngine.now() + 0.05, (e.durationTicks / PPQ) * (60 / sanitizeBpm(configRef.current.bpm)), configRef.current.previewVolume ?? 0.4, PREVIEW_GROUP);
|
||||
});
|
||||
}, [events, setPhaseBoth]);
|
||||
|
||||
const virtualTap = useCallback((midi: number) => {
|
||||
const p = phaseRef.current;
|
||||
@@ -548,6 +641,7 @@ export function usePhraseTrainer(
|
||||
const stop = useCallback(() => {
|
||||
if (repeatTimerRef.current) { clearTimeout(repeatTimerRef.current); repeatTimerRef.current = null; }
|
||||
if (previewTimerRef.current) { clearTimeout(previewTimerRef.current); previewTimerRef.current = null; }
|
||||
if (previewTickRef.current) { clearInterval(previewTickRef.current); previewTickRef.current = null; }
|
||||
audioEngine.cancelGroup(PREVIEW_GROUP);
|
||||
audioEngine.cancelGroup(CLICK_GROUP);
|
||||
runTokenRef.current++;
|
||||
@@ -576,6 +670,7 @@ export function usePhraseTrainer(
|
||||
// Unmount: cancel all scheduled audio and timers.
|
||||
if (repeatTimerRef.current) clearTimeout(repeatTimerRef.current);
|
||||
if (previewTimerRef.current) clearTimeout(previewTimerRef.current);
|
||||
if (previewTickRef.current) clearInterval(previewTickRef.current);
|
||||
audioEngine.cancelGroup(PREVIEW_GROUP);
|
||||
audioEngine.cancelGroup(CLICK_GROUP);
|
||||
}, []);
|
||||
@@ -602,6 +697,7 @@ export function usePhraseTrainer(
|
||||
statuses,
|
||||
currentIdx,
|
||||
countInLeft,
|
||||
previewIdx,
|
||||
scoreStart: scoreStartRef.current,
|
||||
spb: spbRef.current,
|
||||
error,
|
||||
@@ -611,6 +707,7 @@ export function usePhraseTrainer(
|
||||
retry,
|
||||
skip,
|
||||
previewToggle,
|
||||
previewStep,
|
||||
virtualTap,
|
||||
pause,
|
||||
stop,
|
||||
|
||||
@@ -9,7 +9,7 @@ import {
|
||||
NOTE_DISPLAY_STABLE_FRAMES,
|
||||
} from '../AppConfig';
|
||||
|
||||
interface PitchData {
|
||||
export interface PitchData {
|
||||
frequency: number;
|
||||
midi: number;
|
||||
note: string;
|
||||
|
||||
@@ -59,24 +59,24 @@
|
||||
@media (prefers-color-scheme: dark) {
|
||||
:root {
|
||||
color-scheme: dark;
|
||||
--color-bg: hsl(30, 20%, 10%);
|
||||
--color-surface: hsl(30, 20%, 15%);
|
||||
--color-text-main: hsl(30, 10%, 90%);
|
||||
--color-text-muted: hsl(30, 10%, 60%);
|
||||
--color-primary: hsl(0, 0%, 90%);
|
||||
--color-primary-dark: hsl(0, 0%, 100%);
|
||||
--color-bg: hsl(220, 6%, 10%);
|
||||
--color-surface: hsl(220, 6%, 15%);
|
||||
--color-text-main: hsl(220, 4%, 90%);
|
||||
--color-text-muted: hsl(220, 4%, 60%);
|
||||
--color-primary: hsl(220, 4%, 90%);
|
||||
--color-primary-dark: hsl(220, 4%, 100%);
|
||||
}
|
||||
}
|
||||
|
||||
/* Manual Dark Mode Override */
|
||||
html[data-theme="dark"] {
|
||||
color-scheme: dark;
|
||||
--color-bg: hsl(30, 20%, 10%);
|
||||
--color-surface: hsl(30, 20%, 15%);
|
||||
--color-text-main: hsl(30, 10%, 90%);
|
||||
--color-text-muted: hsl(30, 10%, 60%);
|
||||
--color-primary: hsl(0, 0%, 90%);
|
||||
--color-primary-dark: hsl(0, 0%, 100%);
|
||||
--color-bg: hsl(220, 6%, 10%);
|
||||
--color-surface: hsl(220, 6%, 15%);
|
||||
--color-text-main: hsl(220, 4%, 90%);
|
||||
--color-text-muted: hsl(220, 4%, 60%);
|
||||
--color-primary: hsl(220, 4%, 90%);
|
||||
--color-primary-dark: hsl(220, 4%, 100%);
|
||||
}
|
||||
|
||||
/* Manual Light Mode Override */
|
||||
|
||||
@@ -49,8 +49,6 @@ export interface PhraseSettings {
|
||||
material: PhraseMaterial;
|
||||
libraryId: string;
|
||||
/** Imported score id (the parsed score lives in component state, session-only). */
|
||||
keyTonic: string;
|
||||
keyMode: string; // ModeId
|
||||
bars: number; // 1–8 (melodies)
|
||||
meterNumerator: 3 | 4 | 6;
|
||||
rhythmLevel: 1 | 2 | 3;
|
||||
@@ -69,10 +67,6 @@ export interface PhraseSettings {
|
||||
/** Giuliani study material (own category — voicing-enforced). */
|
||||
giulianiPattern: 'pim' | 'pima' | 'pami' | 'aim' | 'pimamim' | 'pmamim' | 'piai' | 'pmami' | 'pimami' | 'pimaia' | 'pimai' | 'pmia' | 'pmim';
|
||||
giulianiBars: number;
|
||||
/** Phrase-local fret window (guitar/bass) — overrides the note set. */
|
||||
fretWindowEnabled: boolean;
|
||||
fretMin: number;
|
||||
fretMax: number;
|
||||
/** Practice range for library/import material (1-based, inclusive). */
|
||||
startBar: number;
|
||||
barCount: number;
|
||||
@@ -95,8 +89,6 @@ export interface PhraseSettings {
|
||||
export const DEFAULT_PHRASE_SETTINGS: PhraseSettings = {
|
||||
material: 'melody',
|
||||
libraryId: '',
|
||||
keyTonic: 'C',
|
||||
keyMode: 'major',
|
||||
bars: 2,
|
||||
meterNumerator: 4,
|
||||
rhythmLevel: 1,
|
||||
@@ -111,9 +103,6 @@ export const DEFAULT_PHRASE_SETTINGS: PhraseSettings = {
|
||||
arpeggioProgression: 'functional',
|
||||
giulianiPattern: 'pima',
|
||||
giulianiBars: 4,
|
||||
fretWindowEnabled: false,
|
||||
fretMin: 0,
|
||||
fretMax: 4,
|
||||
startBar: 1,
|
||||
barCount: 2,
|
||||
pace: 'step',
|
||||
@@ -145,7 +134,12 @@ export interface AppSettings {
|
||||
instrument: string;
|
||||
rhythm: RhythmSettings;
|
||||
zenMode: boolean;
|
||||
gameMode: 'sight_reading' | 'ear_training' | 'phrase';
|
||||
/**
|
||||
* TODO: Rename 'sight_reading' to 'learn_notes' internally (UI label is
|
||||
* already "Learn Notes"). Deferred because the value is persisted in
|
||||
* localStorage — needs a settings migration for existing users.
|
||||
*/
|
||||
gameMode: 'sight_reading' | 'ear_training' | 'phrase' | 'assist';
|
||||
customMinFret?: number;
|
||||
customMaxFret?: number;
|
||||
autoPlaySightReading?: boolean;
|
||||
|
||||
Reference in New Issue
Block a user